Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Adding Office 365 login support using Azure Active Directory OAu… #8248
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
edx-webhook
May 28, 2015
Thanks for the pull request, @vinhub! I've created OSPR-618 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:
- supporting documentation
- edx-code email threads
- timeline information ('this must be merged by XX date', and why that is)
- partner information ('this is a course on edx.org')
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.
We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation and added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information.
edx-webhook
commented
May 28, 2015
Thanks for the pull request, @vinhub! I've created OSPR-618 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here. We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation and added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information. |
edx-webhook
added
open-source-contribution
needs triage
product review
and removed
needs triage
labels
May 28, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
antoviaque
May 29, 2015
Member
@vinhub Python social auth is already being updated as part of the work on SSO/Shibboleth on #8140 - it would be important to sync up with @bradenmacdonald before considering merging this, especially as both rely on changes in the upstream project.
@vinhub Python social auth is already being updated as part of the work on SSO/Shibboleth on #8140 - it would be important to sync up with @bradenmacdonald before considering merging this, especially as both rely on changes in the upstream project. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bradenmacdonald
May 29, 2015
Member
@vinhub This will be a nice contribution!
As @antoviaque mentioned, I've been doing a lot of work around third party auth as part of edX's Shibboleth/SSO project.
If you're feeling a bit adventurous, you may want to try developing this on top of the code that's in #8155 (which includes other code from #8140). That code is still under review and on a separate feature branch, but we're hoping to get it all merged to master
in the near future. The benefits for you from that work already done are:
- It's already upgraded to python-social-auth 0.2.7
- You can now add new providers like this simply by using the Django admin view and entering in the information.
UINAME
is not required because each provider now has aname
and anid
specified in the database, and the names can contain spaces.- The can add a new python-social-auth OAuth2 backend (such as this new Office 365 backend) just by adding its full path (e.g.
social.backends.azuread.AzureADOAuth2
) to the newTHIRD_PARTY_AUTH_BACKENDS
setting. This means, for example, that you can use custom backends that are not even located in the python-social-auth package.
@vinhub This will be a nice contribution! As @antoviaque mentioned, I've been doing a lot of work around third party auth as part of edX's Shibboleth/SSO project. If you're feeling a bit adventurous, you may want to try developing this on top of the code that's in #8155 (which includes other code from #8140). That code is still under review and on a separate feature branch, but we're hoping to get it all merged to
|
edx-webhook
added
community manager review
and removed
product review
labels
May 29, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 1, 2015
Contributor
@vinhub thanks for your contributor's agreement! Can you please sync with @bradenmacdonald regarding your questions, and respond to his as well? Thanks!
@vinhub thanks for your contributor's agreement! Can you please sync with @bradenmacdonald regarding your questions, and respond to his as well? Thanks! |
edx-webhook
added
waiting on author
and removed
community manager review
labels
Jun 1, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
vinhub
Jun 1, 2015
@sarina, @bradenmacdonald
Thanks for your comments. Your suggestion looks very interesting and we are looking into PR #8155. We are under a bit of time pressure, so do you have an approximate ETA for when #8155 (or its successor) might get accepted into the platform?
vinhub
commented
Jun 1, 2015
@sarina, @bradenmacdonald |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 1, 2015
Contributor
@vinhub can you explain your time pressure with a bit more detail? I don't know the background of this project.
@vinhub can you explain your time pressure with a bit more detail? I don't know the background of this project. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
Jun 2, 2015
@sarina Our team (me, @vinhub , and others from http://www.MSOpenTech.com/ ) is trying to coordinate the available of this functionality with some other Microsoft + Educational OSS interoperability and announcements. If @bradenmacdonald 's #8155 gets picked-up in the next 5-7 days, that would be awesome. If it's more like 30+ days, that would be non-optimal for us. Thanks.
RobDolinMS
commented
Jun 2, 2015
@sarina Our team (me, @vinhub , and others from http://www.MSOpenTech.com/ ) is trying to coordinate the available of this functionality with some other Microsoft + Educational OSS interoperability and announcements. If @bradenmacdonald 's #8155 gets picked-up in the next 5-7 days, that would be awesome. If it's more like 30+ days, that would be non-optimal for us. Thanks. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 8, 2015
Contributor
@RobDolinMS - I understand you spoke with Beth last week regarding this pull request. Is there anything you need me to do as a follow up from that?
@RobDolinMS - I understand you spoke with Beth last week regarding this pull request. Is there anything you need me to do as a follow up from that? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
Jun 10, 2015
@sarina - Thanks for checking. We've connected with @bradenmacdonald via email and I believe his changes will satisfy most of the goals of this PR.
RobDolinMS
commented
Jun 10, 2015
@sarina - Thanks for checking. We've connected with @bradenmacdonald via email and I believe his changes will satisfy most of the goals of this PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 15, 2015
Contributor
@RobDolinMS thanks for the update. Does this pull request still need to be reviewed, then, if Braden's changes will satisfy your requirements?
@RobDolinMS thanks for the update. Does this pull request still need to be reviewed, then, if Braden's changes will satisfy your requirements? |
bradenmacdonald
referenced this pull request
Jun 19, 2015
Merged
Bump python-social-auth to upstream's latest master #8599
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
commented
Jun 22, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@RobDolinMS great, thanks. Can this PR be closed, then? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jul 1, 2015
Contributor
OK, I didn't receive a response and the PRs in question have been merged so I'm closing this. Thanks!
OK, I didn't receive a response and the PRs in question have been merged so I'm closing this. Thanks! |
sarina
closed this
Jul 1, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
commented
Jul 1, 2015
Thanks for closing @sarina. |
vinhub commentedMay 28, 2015
…th2 provider and related changes
The code is working, but it is WIP because we have a couple of issues that we would like to get reviewed: