Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBump python-social-auth to upstream's latest master #8599
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
edx-webhook
Jun 19, 2015
Thanks for the pull request, @bradenmacdonald! I've created OSPR-669 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:
- supporting documentation
- edx-code email threads
- timeline information ('this must be merged by XX date', and why that is)
- partner information ('this is a course on edx.org')
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.
edx-webhook
commented
Jun 19, 2015
Thanks for the pull request, @bradenmacdonald! I've created OSPR-669 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Jenkins, test this please. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
commented
Jun 22, 2015
RobDolinMS
referenced this pull request
Jun 22, 2015
Closed
WIP: Adding Office 365 login support using Azure Active Directory OAu… #8248
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@cpennington This is ready for your review. (It's small) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@bradenmacdonald do you have a link to the diff of the changes? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 23, 2015
Contributor
@bradenmacdonald and/or release notes? that would help evaluate the change.
@bradenmacdonald and/or release notes? that would help evaluate the change. |
edx-webhook
added
open-source-contribution
needs triage
awaiting prioritization
and removed
needs triage
labels
Jun 23, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 23, 2015
Contributor
@cpennington should the platform team or destination team review this?
@cpennington should the platform team or destination team review this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bradenmacdonald
Jun 23, 2015
Member
@sarina The upstream changelog is here. The platform is currently using python-social-auth version 0.2.7, and this bumps it to the upcoming release that will probably be called v 0.2.11.
The changelog entries that seem to potentially be relevant to us are:
- SAML Backend
- Avoid storing empty values from user details
- Added provider for Microsoft Azure Active Directory OAuth2
- Fixes "ImportError: No module named packages.urllib3.poolmanager" error (bumps 'requests' version)
- Make URLs trailing slash be configurable by setting. Refs #505
@sarina The upstream changelog is here. The platform is currently using python-social-auth version 0.2.7, and this bumps it to the upcoming release that will probably be called v 0.2.11. The changelog entries that seem to potentially be relevant to us are:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
cpennington
Jun 23, 2015
Member
@sarina I took a brief skim, but its probably worth destination edx look a little closer.
@sarina I took a brief skim, but its probably worth destination edx look a little closer. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rlucioni
Jun 23, 2015
Contributor
@bradenmacdonald I've found omab to be very responsive to version bump requests. Have you tried asking him to release 0.2.11 on PyPI?
@bradenmacdonald I've found omab to be very responsive to version bump requests. Have you tried asking him to release 0.2.11 on PyPI? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@rlucioni Good idea. I've just asked him now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RobDolinMS
Jun 23, 2015
@sarina I see that this has the label "Awaiting Prioritization" Can this be given the necessary priority to make sure it is included in this release?
RobDolinMS
commented
Jun 23, 2015
@sarina I see that this has the label "Awaiting Prioritization" Can this be given the necessary priority to make sure it is included in this release? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 24, 2015
Contributor
Renzo has already started reviewing this. I will try my hardest but we are
beset with performance issues right now; < 1 week is really tight
turnaround for a pull request exactly because unanticipated issues may come
up at any moment.
On Tue, Jun 23, 2015 at 7:53 PM, Rob Dolin notifications@github.com wrote:
@sarina https://github.com/sarina I see that this has the label
"Awaiting Prioritization" Can this be given the necessary priority to make
sure it is included in this release?—
Reply to this email directly or view it on GitHub
#8599 (comment).
Renzo has already started reviewing this. I will try my hardest but we are On Tue, Jun 23, 2015 at 7:53 PM, Rob Dolin notifications@github.com wrote:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sarina
Jun 24, 2015
Contributor
Keep in mind if your goal is by the end of the week to make Cypress, we
will be cutting Cypress after SSO has merged. So that should not be a
concern.
On Tue, Jun 23, 2015 at 9:48 PM, Sarina Canelake sarina@edx.org wrote:
Renzo has already started reviewing this. I will try my hardest but we are
beset with performance issues right now; < 1 week is really tight
turnaround for a pull request exactly because unanticipated issues may come
up at any moment.On Tue, Jun 23, 2015 at 7:53 PM, Rob Dolin notifications@github.com
wrote:@sarina https://github.com/sarina I see that this has the label
"Awaiting Prioritization" Can this be given the necessary priority to make
sure it is included in this release?—
Reply to this email directly or view it on GitHub
#8599 (comment).
Keep in mind if your goal is by the end of the week to make Cypress, we On Tue, Jun 23, 2015 at 9:48 PM, Sarina Canelake sarina@edx.org wrote:
|
rlucioni
reviewed
Jun 24, 2015
View changes
requirements/edx/github.txt Outdated
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
omab
commented
Jun 24, 2015
FYI, python-social-auth |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Thanks for the heads-up @omab. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bradenmacdonald
Jun 24, 2015
Member
I just updated this PR to use 0.2.11 and tested it locally - everything seems great. 3 of the 4 python-saml PRs have been merged so far so I'll watch for a new release of that as well, and then do a final update of this.
I just updated this PR to use 0.2.11 and tested it locally - everything seems great. 3 of the 4 python-saml PRs have been merged so far so I'll watch for a new release of that as well, and then do a final update of this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bradenmacdonald
Jun 25, 2015
Member
A new version of python-saml
was released today that included three of my four changes plus an alternative to my other proposed change. I have updated this PR and its description accordingly. We can now use PyPI versions for both of the new python packages needed for Shibboleth/SSO :)
I have switched http://sandbox5.opencraft.com to use these PyPI versions and confirmed that it is still working with our test Shibboleth providers (TestShib and UBC).
@Kelketek Can you please take another look and confirm that your +1 stands?
@rlucioni I think this is ready for a final look.
Build failure is unrelated and has been fixed on master, but I'd rather not rebase the feature branch while there are four open PRs against it undergoing active review.
A new version of I have switched http://sandbox5.opencraft.com to use these PyPI versions and confirmed that it is still working with our test Shibboleth providers (TestShib and UBC). @Kelketek Can you please take another look and confirm that your +1 stands? Build failure is unrelated and has been fixed on master, but I'd rather not rebase the feature branch while there are four open PRs against it undergoing active review. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rlucioni
Jun 25, 2015
Contributor
@bradenmacdonald
@bradenmacdonald |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
test this please |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rlucioni
Jun 25, 2015
Contributor
@Kelketek as @bradenmacdonald wrote, the single failing test is unrelated and has been fixed in master. I'm going to go ahead and merge this.
@Kelketek as @bradenmacdonald wrote, the single failing test is unrelated and has been fixed in master. I'm going to go ahead and merge this. |
bradenmacdonald commentedJun 19, 2015
Summary
The python-social-auth and python-saml projects have merged our changes. This switches us back to using official PyPI releases, which are now compatible with our new SAML backend.
This also pulls in the OAuth2 backend required to support Office 365 logins, therefore providing a replacement for most of #8248.
This is part of the Shibboleth/SSO work and is being merged to the shibboleth-tpa feature branch
Details
Noteworthy changelog entries between python-social-auth version 0.2.7 and 0.2.11:
For python-saml, the only commits added to the PyPI release that weren't previously included in our fork are:
Sandbox:
http://sandbox5.opencraft.com/login has been updated to use the new versions via PyPI (on June 24)
Reviewers
@Kelketek and @rlucioni