Fix undefined method: inject for String #20

robbat2 · January 11, 2013

The physical_volumes extraction using inject function doesn't work.
Change to using split/grep/map.

/Stage[main]/Releng::Disks/Volume_groupvg: Could not evaluate: undefined method `inject' for " PV,VG\n/dev/sda4,vg\n":String

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

adrienthebo · January 18, 2013

For clarification, this fix is necessary because Ruby 1.9 removed String#inject. I've checked it and it looks good.

adrienthebo merged commit b831542 into puppetlabs:master from unknown repository January 18, 2013

adrienthebo closed this January 18, 2013

@@ -32,14 +32,9 @@ def physical_volumes=(new_volumes = [])
      def physical_volumes
          lines = pvs('-o', 'pv_name,vg_name', '--separator', ',')
--        lines.inject([]) do |memo, line|
--            pv, vg = line.split(',').map { |s| s.strip }
--            if vg == @resource[:name]
--                memo << pv
--            else
--                memo
--            end
--        end
++        lines.split(/\n/).grep(/,#{@resource[:name]}$/).map { |s|
++            s.split(/,/)[0].strip
++        }
      end
      private

puppetlabs/puppetlabs-lvm