Pushing a pull request doesn't close it

#1

Weird bug in the Integration API. If you merge a pull request by force-pushing, like this, the PR will be marked as merged, but will not be closed:

curl -X PATCH -H "Authorization: token v1.CENSORED" https://api.github.com/repos/notriddle/test_repo/git/refs/heads/master -d '{"sha":"7bd3e0daa0f8a26614fa7788b363f7c8c6d09d6f","force":true}'

[where 7bd3e0daa0f8a26614fa7788b363f7c8c6d09d6f is the commit at the head of the pull request]

The pull request will be marked as merged, but will not be closed. This only happens when you're acting as an Integration: if you use a Personal Access Token, it will work correctly.

Screenshot for permanent proof:

screenshot.png1195x787 72 KB

And a link to prove I didn't just photoshop it: https://github.com/notriddle/test_repo/pulls

Pull requests open after merge
#2

BTW, it also doesn't close issues that are named with the "Closes #XXX" syntax in the commit, either.

#3

It also won't rebuild GitHub Pages when an integration pushes to it.

#4

Hey @notriddle - Thanks for reporting this behavior. I've opened a ticket for us to investigate and will update here when we know more.

#5

Hey @notriddle! We just shipped a fix for this to production, so your integration should correctly mark pull requests as closed when they get merged now. Please keep in mind that your integration will need write permissions to pull requests and issues as well. Thanks again for reporting this!

#6