New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6: force goUSFormatSettings during JSON write #7

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
2 participants
@jpluimers
Copy link
Contributor

jpluimers commented Oct 25, 2018

Small glitch: ensure goUSFormatSettings is used during JSON write in the unit tests.

This makes the reading and writing format settings symmetric, and fixes tests in countries having a decimal comma (where the tests fail for instance because the read double 12.3 is not the same as the double written to string as 12,3).

@erikvanbilsen erikvanbilsen merged commit 490e205 into grijjy:master Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment