Opened 11 years ago

Closed 11 years ago

#11437 closed enhancement (fixed)

rubiks: apply gcc 4.6.x workaround only for gcc 4.6.0 and 4.6.1

Reported by: jdemeyer Owned by: tbd
Priority: major Milestone: sage-4.7.1
Component: packages: standard Keywords: rubiks spkg gcc
Cc: Merged in: sage-4.7.1.alpha3
Authors: Jeroen Demeyer Reviewers: Mariah Lenox
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Since bug #11168 (rubiks fails doctest with gcc 4.6.0 and -O2 optimisation) is fixed upstream by the gcc developers, we should apply the workaround only for gcc versions 4.6.0 and 4.6.1 (the latter to allow for pre-release versions of gcc 4.6.1), exactly like we did for Cliquer (#11227).

spkg: ​http://boxen.math.washington.edu/home/jdemeyer/spkg/rubiks-20070912.p17.spkg

Attachments (1)

rubiks-20070912.p16-p17.diff​ (1.2 KB) - added by jdemeyer 11 years ago.
Diff for the rubiks spkg, for reviewing only

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Status changed from new to needs_review

Changed 11 years ago by jdemeyer

Diff for the rubiks spkg, for reviewing only

comment:2 Changed 11 years ago by mariah

  • Reviewers set to Mariah Lenox
  • Status changed from needs_review to positive_review

Put the proposed spkg in source of sage-4.7.1.alpha1, built using gcc-4.6.0 with 'make testlong'. All tests passed. Positive review!

comment:3 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.