Opened 9 years ago

Closed 9 years ago

#12570 closed defect (fixed)

remove xcodebuild check from Mercurial

Reported by: jdemeyer Owned by: tbd
Priority: critical Milestone: sage-5.0
Component: packages: standard Keywords:
Cc: Merged in: sage-5.0.beta7
Authors: Jeroen Demeyer Reviewers: Dmitrii Pasechnik, John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

#12416 disables extra flags for XCode 4, but the check for the XCode version is still in place. Remove it completely, as XCode 4.3 doesn't have xcodebuild by default.

spkg: ​http://boxen.math.washington.edu/home/jdemeyer/spkg/mercurial-1.8.4.p1.spkg

Attachments (1)

mercurial-1.8.4.p1.diff​ (2.1 KB) - added by jdemeyer 9 years ago.
Diff for the mercurial spkg, for review only

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

Changed 9 years ago by jdemeyer

Diff for the mercurial spkg, for review only

comment:2 Changed 9 years ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 9 years ago by dimpase

It fixes a problem I just had building 5.0.beta6 on sqrt5.cs.washington.edu. As it seems to have an unusual configuration, I refrain from setting the positive_review on (it's my 1st attempt to work with OSX 10.7)

comment:4 Changed 9 years ago by jhpalmieri

  • Reviewers set to Dmitrii Pasechnik, John Palmieri
  • Status changed from needs_review to positive_review

This works for me on both OS X 10.6 and OS X 10.7. I think we can give it a positive review.

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.