Opened 11 years ago

Closed 8 years ago

#12759 closed defect (fixed)

Maxima 5.26.0 fails to build with multiple words in LDFLAGS

Reported by: Leif Leonhardy Owned by: Leif Leonhardy
Priority: critical Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: spkg linker unrecognized option
Cc: Simon King, Jason Grout Merged in:
Authors: Leif Leonhardy Reviewers: Ralf Stephan, Peter Bruin
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13860 Stopgaps:

Status badges

Description (last modified by Leif Leonhardy)

I already have an spkg working around this, as well as using ecl -norc ... as recommended by an ECL developer.

To reproduce the problem, just try something like 

$ env LDFLAGS="-DFOO -DBAR" ./sage -f spkg/standard/maxima-5.26.0.p0.spkg

New spkg: ​http://boxen.math.washington.edu/home/leif/Sage/spkgs/maxima-5.26.0.p1.spkg

md5sum: e0dd8b63928fbef1ffa52420f1313c48 maxima-5.26.0.p1.spkg

maxima-5.26.0.p1 (Leif Leonhardy, March 25th 2012)

  • #12759: Unset LDFLAGS if it contains multiple words. (ECL's still get used in that case, but don't break the build.)
  • Use ecl -norc ... throughout spkg-install, as recommended by Juanjo. We set the environment variable ECL to this, which *might* get used by Makefiles as well -- to be checked. (I.e., we might have to pass e.g. ECL="$ECL" when invoking make to override Makefile settings, in case that's desired.)
  • Use cp -pf ... to preserve permissions and to avoid errors if files already exist (read-only).
  • Add some error checks, messages and comments; quote more variables.

Attachments (1)

maxima-5.26.0.p0-p1.diff​ (5.3 KB) - added by Leif Leonhardy 11 years ago.
Diff between the previous spkg in Sage and my new p1 spkg. For reference / review only.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by Leif Leonhardy

Attachment: maxima-5.26.0.p0-p1.diff​ added

Diff between the previous spkg in Sage and my new p1 spkg. For reference / review only.

comment:1 Changed 11 years ago by Leif Leonhardy

Authors: → Leif Leonhardy
Cc: Simon King Jason Grout added
Description: modified (diff)
Status: new → needs_review

I've also added a comment regarding the contained PDF files to SPKG.txt (cf. attached diff).

comment:2 Changed 10 years ago by Leif Leonhardy

Summary: Maxima fails to build with multiple words in LDFLAGS → Maxima 5.26.0 fails to build with multiple words in LDFLAGS

Looks like the main issue (i.e., multiple words in LDFLAGS) meanwhile got fixed upstream (as of Maxima 5.29.1, see #13364); I'll probably try to incorporate the other fixes into the Maxima spkg there.

comment:3 Changed 10 years ago by Leif Leonhardy

Dependencies: → #13860
Status: needs_review → needs_work
Work issues: → Rebase

comment:4 Changed 10 years ago by Leif Leonhardy

Personal note: Deletion of unused PDF files belongs to spkg-dist and/or Special Update/Build Instructions.

comment:5 Changed 10 years ago by Jeroen Demeyer

Can this be closed as duplicate of #13364?

comment:6 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11 → sage-5.12

comment:7 Changed 9 years ago by For batch modifications

Milestone: sage-6.1 → sage-6.2

comment:8 Changed 8 years ago by For batch modifications

Milestone: sage-6.2 → sage-6.3

comment:9 Changed 8 years ago by For batch modifications

Milestone: sage-6.3 → sage-6.4

comment:10 Changed 8 years ago by Ralf Stephan

Milestone: sage-6.4 → sage-duplicate/invalid/wontfix
Status: needs_work → needs_review
Work issues: Rebase

env LDFLAGS="-DFOO -DBAR" ./sage -f maxima works fine so I guess it's no longer an issue.

comment:11 Changed 8 years ago by Peter Bruin

Reviewers: → Ralf Stephan, Peter Bruin
Status: needs_review → positive_review

This indeed appears to be fixed, as far as I can see.

comment:12 Changed 8 years ago by Volker Braun

Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.