Opened 10 years ago

Closed 10 years ago

#13513 closed enhancement (fixed)

Has standard involution function for algebras.

Reported by: schisholm Owned by: AlexGhitza
Priority: minor Milestone: sage-5.5
Component: algebra Keywords: Standard Involution
Cc: aly.deines Merged in: sage-5.5.rc0
Authors: Sarah Chisholm Reviewers: Aly Deines
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This algorithm follows John Voight's Alg. 2.10 in Identifying the Matrix Ring. This currently works only for quaternion algebras. The goal is to make it more functional once Algebras have more functionality.

Attachments (1)

standard_involution.patch​ (2.6 KB) - added by schisholm 10 years ago.
Version 2

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by aly.deines

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by aly.deines

  • Reviewers set to Aly Deines
  • Status changed from needs_review to positive_review

comment:3 Changed 10 years ago by jdemeyer

  • Authors changed from schisholm to Sarah Chisholm

comment:4 Changed 10 years ago by jdemeyer

Never use 

try:
    ...
except:
    ...

(this catching thinks like KeyboardInterrupt and SystemExit which you really don't want). You should always catch a specific exception, like: 

try:
    ...
except AttributeError:
    ...

comment:5 Changed 10 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Changed 10 years ago by schisholm

Version 2

comment:6 Changed 10 years ago by schisholm

  • Status changed from needs_work to needs_review

comment:7 Changed 10 years ago by aly.deines

  • Priority changed from major to minor
  • Status changed from needs_review to positive_review

comment:8 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-5.4 to sage-5.5

comment:9 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.5.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.