Opened 9 years ago

Closed 9 years ago

#14463 closed enhancement (fixed)

cleanup of the file gsl/dft.py

Reported by: chapoton Owned by: mvngu
Priority: minor Milestone: sage-5.10
Component: doctest coverage Keywords: documentation
Cc: Merged in: sage-5.10.beta1
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

a patch to clean up a little bit the file sage/gsl.dft.py

(which deals with discrete Fourier transform)

  • add missing doc to reach 100% coverage
  • format the existing doc
  • put raise statements into python3 syntax
  • remove trailing whitespaces

Attachments (2)

trac_14463_cleanup_discretefourier-fc.patch​ (32.9 KB) - added by chapoton 9 years ago.
trac_14463-cleanup_dft-review-ts.patch​ (24.4 KB) - added by tscrim 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by chapoton

comment:1 Changed 9 years ago by chapoton

  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from cleanup of the file gsl/dsl.py to cleanup of the file gsl/dft.py

comment:2 Changed 9 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Hey Frederic,

Here's a review patch which does some more formatting and adds in its sister modules of dwt.pyx and fft.pyx (and just makes it so that they don't throw docbuilding errors). If you agree with my changes, feel free to set this to positive review.

Best,
Travis

comment:3 Changed 9 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, looks good to me, positive review

Changed 9 years ago by tscrim

comment:4 Changed 9 years ago by tscrim

Thanks Frederic.

(Added forgotten commit message to patch.)

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.10.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.