Opened 8 years ago

Closed 8 years ago

#1639 closed defect (fixed)

[with patch, positive review] missing documentation P.completion()

Reported by: schilly Owned by: failure
Priority: trivial Milestone: sage-2.10.3
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

How works completion?

P.<x> = PolynomialRing(QQ); P.completion?


tells me

File:        /opt/sage/local/lib/python2.5/site-packages/sage/rings/polynomial/polynomial_ring.py
Type:        <type 'instancemethod'>
Definition:  P.completion(p, prec, extras)
Docstring: 
x.__init__(...) initializes x; see x.__class__.__doc__ for signature


what's the p and examples are missing...

Attachments (1)

8316.patch​ (1.7 KB) - added by cremona 8 years ago.
adds docstring and examples

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by mabshoff

  • Milestone set to sage-2.9.2

comment:2 Changed 8 years ago by AlexGhitza

  • Component changed from documentation to doctest
  • Owner changed from tba to failure

Changed 8 years ago by cremona

adds docstring and examples

comment:3 Changed 8 years ago by cremona

  • Summary changed from missing documentation P.completion() to [with patch, needs review] missing documentation P.completion()

The attached patch adds docstring and tests.

This ticket should perhaps be kept open in another form so that someone could implement the completion function for irreducuble polynomials other than just x. I am happy to be the owner of that.

comment:4 Changed 8 years ago by mhansen

  • Summary changed from [with patch, needs review] missing documentation P.completion() to [with patch, positive review] missing documentation P.completion()

Applies to 2.10.3.alpha0 and passes tests for me.

comment:5 Changed 8 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.3.rc0

Note: See TracTickets for help on using tickets.