Opened 9 years ago

Closed 8 years ago

#16756 closed defect (fixed)

Fully make lrcalc standard

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.4
Component: build Keywords: lrcalc deps
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: f17aaad (Commits, GitHub, GitLab) Commit: f17aaad6f47e88558d4f6d59277c206b5849de8b
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

build/deps should reflect the dependency of sage on lrcalc.

Change History (7)

comment:1 Changed 9 years ago by jdemeyer

Authors: → Jeroen Demeyer
Description: modified (diff)

comment:2 Changed 9 years ago by jdemeyer

Branch: → u/jdemeyer/ticket/16756
Created: Aug 4, 2014, 1:55:26 PM → Aug 4, 2014, 1:55:26 PM
Modified: Aug 4, 2014, 2:00:41 PM → Aug 4, 2014, 2:00:41 PM

comment:3 Changed 9 years ago by jdemeyer

Commit: → f17aaad6f47e88558d4f6d59277c206b5849de8b
Status: new → needs_review

New commits:

​f17aaadAdd LRCALC as dependency of sage

comment:4 Changed 9 years ago by jhpalmieri

Keywords: lrcalc deps added
Reviewers: → John Palmieri
Status: needs_review → positive_review

Looks okay to me. I guess the files in src/sage/libs/lrcalc demonstrate that this is a build-time dependency, not just a run-time one?

comment:5 in reply to:  4 Changed 9 years ago by jdemeyer

Replying to jhpalmieri:

Looks okay to me. I guess the files in src/sage/libs/lrcalc demonstrate that this is a build-time dependency, not just a run-time one?

It is indeed a build dependency, look at src/module_list.py which has 

if is_package_installed('lrcalc'):
    ext_modules.append(
        Extension('sage.libs.lrcalc.lrcalc',
                  sources = ["sage/libs/lrcalc/lrcalc.pyx"],
                  include_dirs = [SAGE_INC + '/lrcalc/'],
                  libraries = ["lrcalc"],
                  depends = [SAGE_INC + "/lrcalc/symfcn.h"]), # should include all .h
        )

comment:6 Changed 8 years ago by vbraun_spam

Milestone: sage-6.3 → sage-6.4

comment:7 Changed 8 years ago by vbraun

Branch: u/jdemeyer/ticket/16756 → f17aaad6f47e88558d4f6d59277c206b5849de8b
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.