Opened 15 years ago
Closed 15 years ago
#1761 closed enhancement (fixed)
[with patch, positive review] Graphviz output for graphs
| Reported by: | Kelly Boothby | Owned by: | Robert Miller |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-3.0 |
| Component: | graph theory | Keywords: | graph visualization dot graphviz |
| Cc: | ncalexan | Merged in: | |
| Authors: | Reviewers: | ||
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
Add functionality to use graphviz for graph display.
Attachments (4)
Change History (12)
Changed 15 years ago by
| Attachment: | graphviz.hg added |
|---|
comment:1 Changed 15 years ago by
| Summary: | Graphviz output for graphs → [with bundle, needs review] Graphviz output for graphs |
|---|
comment:2 Changed 15 years ago by
| Milestone: | → sage-2.10 |
|---|
comment:3 Changed 15 years ago by
| Summary: | [with bundle, needs review] Graphviz output for graphs → [with bundle, with mostly positive review] Graphviz output for graphs |
|---|
comment:4 Changed 15 years ago by
| Summary: | [with bundle, with mostly positive review] Graphviz output for graphs → [with bundle, with two mostly positive reviews, but changes recommended] Graphviz output for graphs |
|---|
I agree with ncalexan:
- The string functions should be abstracted to the GenericGraph? class with the string changing depending on whether the graph is directed or not. In general, we are trying to consolidate functionality to the GenericGraph? class when possible these days.
- The graphviz function documentation should clearly state that graphviz (and in particular, dot) needs to be installed in the system path. It would be nice were the option to run the other graphviz programs, like neato, etc.
comment:5 Changed 15 years ago by
| Cc: | ncalexan added |
|---|---|
| Keywords: | graph visualization dot graphviz added |
| Summary: | [with bundle, with two mostly positive reviews, but changes recommended] Graphviz output for graphs → [with patch, needs review] Graphviz output for graphs |
The attached patch addresses the referee's comments.
It also removes references to the actual graphviz/dot application. I don't see how this can be made cross-platform and I'm worried about licensing issues, so I'm just ducking the issue. Open a new ticket if you'd like this functionality.
Changed 15 years ago by
| Attachment: | 1761-ncalexan-graphviz-1.patch added |
|---|
comment:7 Changed 15 years ago by
| Summary: | [with patch, needs review] Graphviz output for graphs → [with patch, positive review] Graphviz output for graphs |
|---|
Looks good to me.
comment:8 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Merged in Sage 3.0.alpha3
Changed 15 years ago by
| Attachment: | trac_1761-tmp-file-dir-fix.patch added |
|---|
create doctest files in SAGE_TESTDIR
Note: See
TracTickets for help on using
tickets.
This is useful and should be applied. I would have liked to see the actual function abstracted to a Graph class higher in the hierarchy, if there is one, because it seems like the actual code is the same, just the edge identifier symbols for dot are different. Also, is '# not tested' the correct tag for doctests to not get run?