Opened 6 years ago

Closed 6 years ago

#18573 closed defect (fixed)

Fix build of tides package

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: packages: optional Keywords:
Cc: vbraun, mmarco Merged in:
Authors: Jeroen Demeyer Reviewers: Miguel Marco
Report Upstream: N/A Work issues:
Branch: 45d0a5a (Commits, GitHub, GitLab) Commit: 45d0a5ae4ebce664f35741007e14539a0cf37f49
Dependencies: Stopgaps:

Status badges

Description

tides has this in upstream's Makefile.am: 

AM_CPPFLAGS = -I/usr/local/include

This should be fixed since it may include unwanted stuff from /usr/local/include.

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_build_of_tides_package

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 577642b740a7d8a0814ab4da7dc02bd35c4c04f2
  • Status changed from new to needs_review

New commits:

​577642bFix tides build

comment:3 Changed 6 years ago by git

  • Commit changed from 577642b740a7d8a0814ab4da7dc02bd35c4c04f2 to 45d0a5ae4ebce664f35741007e14539a0cf37f49

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​45d0a5aFix tides build

comment:4 Changed 6 years ago by tmonteil

  • Cc mmarco added

comment:5 Changed 6 years ago by mmarco

Shouldn't it be 

$MAKE AM_CPPFLAGS="-I$SAGE_LOCAL/include"

instead of 

$MAKE AM_CPPFLAGS="-I $SAGE_LOCAL/include"

?

comment:6 Changed 6 years ago by jdemeyer

None of the above :-)

I'm using 

$MAKE AM_CPPFLAGS="-I '$SAGE_LOCAL/include'"

Just look at the make logs, the output is correct.

comment:7 Changed 6 years ago by mmarco

  • Reviewers set to Miguel Marco
  • Status changed from needs_review to positive_review

ok then

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_build_of_tides_package to 45d0a5ae4ebce664f35741007e14539a0cf37f49
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.