Opened 7 years ago

Closed 7 years ago

#19174 closed enhancement (fixed)

new style database_jones_numfield package

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.9
Component: packages: optional Keywords:
Cc: ncohen, was Merged in:
Authors: Dima Pasechnik Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: e1900ef (Commits, GitHub, GitLab) Commit: e1900ef6647d272998bd11ded080b61f487a6194
Dependencies: Stopgaps:

Status badges

Description

the subject says it all.

Pick the tarball from ​http://users.ox.ac.uk/~coml0531/sage/database_jones_numfield-4.tar.gz

Change History (12)

comment:1 Changed 7 years ago by dimpase

Status: new → needs_review

comment:2 Changed 7 years ago by dimpase

Authors: → Dima Pasechnik

comment:3 Changed 7 years ago by ncohen

SPKG.txt ?

comment:4 Changed 7 years ago by ncohen

Reviewers: → Nathann Cohen
Status: needs_review → needs_work

It seems that there was none in the old spkg. Well. Could you add a quick one? There is a model there: ​http://doc.sagemath.org/html/en/developer/packaging.html#the-spkg-txt-file

You can then set this ticket to positive_review: I checked that the content is exactly the content of the old .spkg, installed it and ran the tests.

Thanks,

Nathann

comment:5 Changed 7 years ago by jdemeyer

Summary: new style jone_numfield package → new style database_jones_numfield package

comment:6 Changed 7 years ago by git

Commit: 8f90d430fe07cce819edaae0808b8d4b29ce4c3b → 3f05235e2ae4d1f8e1bd0a32ca3f2a1ad140eb89

Branch pushed to git repo; I updated commit sha1. New commits:

​3f05235SPKG.txt added

comment:7 Changed 7 years ago by dimpase

Status: needs_work → positive_review

comment:8 Changed 7 years ago by jdemeyer

Status: positive_review → needs_work

ahem... 

= PACKAGE_NAME =

comment:9 Changed 7 years ago by git

Commit: 3f05235e2ae4d1f8e1bd0a32ca3f2a1ad140eb89 → e1900ef6647d272998bd11ded080b61f487a6194

Branch pushed to git repo; I updated commit sha1. New commits:

​e1900efSPKG.txt fixed

comment:10 Changed 7 years ago by dimpase

Status: needs_work → needs_review

oops, sorry. Fixed.

comment:11 Changed 7 years ago by dimpase

Status: needs_review → positive_review

comment:12 Changed 7 years ago by vbraun

Branch: u/dimpase/jones_numfield → e1900ef6647d272998bd11ded080b61f487a6194
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.