Opened 7 years ago
Closed 7 years ago
#20341 closed enhancement (fixed)
Add to_digraph method to RecursivelyEnumeratedSet
Reported by: | Sébastien Labbé | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.2 |
Component: | combinatorics | Keywords: | |
Cc: | Merged in: | ||
Authors: | Sébastien Labbé | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | c9a8067 (Commits, GitHub, GitLab) | Commit: | c9a8067565cc8f74d65cea6d08419c53506a2e2c |
Dependencies: | Stopgaps: |
Description
sage: f = lambda a: [a+1, a+I] sage: C = RecursivelyEnumeratedSet([0], f, structure='graded') sage: C.to_digraph(max_depth=4) Looped multi-digraph on 21 vertices
Change History (6)
comment:1 Changed 7 years ago by
Branch: | → u/slabbe/20341 |
---|---|
Commit: | → 2c36bbb685084ae6f137e40a3435183c3abcc700 |
Status: | new → needs_review |
comment:2 Changed 7 years ago by
Commit: | 2c36bbb685084ae6f137e40a3435183c3abcc700 → 86fe5cef16365cdd896df09fe24f6c5e5291946c |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
86fe5ce | 20341: adding to_digraph to recursively_enumerated_set
|
comment:3 Changed 7 years ago by
Reviewers: | → Travis Scrimshaw |
---|
A few small things:
- Make
Default
->default
and remove the period from the first input? - De-indent the output.
- Change
.. NOTE::
to.. WARNING::
.
LGTM otherwise. So once you make those changes, you can set a positive review on my behalf.
comment:4 Changed 7 years ago by
Commit: | 86fe5cef16365cdd896df09fe24f6c5e5291946c → c9a8067565cc8f74d65cea6d08419c53506a2e2c |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
c9a8067 | 20341: fixing reviewer comments
|
comment:5 Changed 7 years ago by
Status: | needs_review → positive_review |
---|
comment:6 Changed 7 years ago by
Branch: | u/slabbe/20341 → c9a8067565cc8f74d65cea6d08419c53506a2e2c |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
#20341: adding to_digraph to recursively_enumerated_set