Opened 6 years ago

Closed 6 years ago

#21096 closed enhancement (fixed)

sage.structure.debug_options should be cimported

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.3
Component: performance Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: fb6ef31 (Commits, GitHub, GitLab) Commit: fb6ef318da829afa2f566e038c85c391413ffd1b
Dependencies: Stopgaps:

Status badges

Description

Obvious low-hanging optimization fruit.

Change History (5)

comment:1 Changed 6 years ago by Jeroen Demeyer

Branch: → u/jdemeyer/sage_structure_debug_options_should_be_cimported

comment:2 Changed 6 years ago by Jeroen Demeyer

Commit: → fb6ef318da829afa2f566e038c85c391413ffd1b
Status: new → needs_review

New commits:

​fb6ef31sage.structure.debug_options should be cimported

comment:3 Changed 6 years ago by Marc Mezzarobba

Reviewers: → Marc Mezzarobba
Status: needs_review → positive_review

LGTM, but I imagined this was intended to speed up parent creation, and I couldn't find an example where it made a measurable difference. Do you have one?

comment:4 in reply to:  3 Changed 6 years ago by Jeroen Demeyer

Replying to mmezzarobba:

LGTM, but I imagined this was intended to speed up parent creation, and I couldn't find an example where it made a measurable difference. Do you have one?

I don't think so. Anyway, this is a relatively old ticket and I don't remember the reason for creating the ticket. Probably it was just an easy fix that I saw.

And by the way, this ugliness 

from cpython.object cimport PyObject
cdef extern from *:
    PyObject* __pyx_d

(<object>__pyx_d)["debug"] = debug

will be better once Cython 0.25 comes out.

comment:5 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/sage_structure_debug_options_should_be_cimported → fb6ef318da829afa2f566e038c85c391413ffd1b
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.