Opened 6 years ago
Closed 6 years ago
#21250 closed enhancement (fixed)
py3: handling removed attributes func_* and im_*
| Reported by: | Frédéric Chapoton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-7.4 |
| Component: | python3 | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Frédéric Chapoton | Reviewers: | Jeroen Demeyer |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 53ada45 (Commits, GitHub, GitLab) | Commit: | 53ada4539978b91c61ae2622d27ce64c8747f067 |
| Dependencies: | Stopgaps: |
Status badges
Description
according to
http://python3porting.com/stdlib.html#removedmodules-section
we should no longer used the attributes func_* and im_* in py3
six provides a way to be py2/py3 compatible.
Change History (14)
comment:1 Changed 6 years ago by
| Branch: | → u/chapoton/21250 |
|---|---|
| Commit: | → c0524a494e946af350be158c48f757db17024e90 |
comment:2 Changed 6 years ago by
src/sage/categories/coercion_methods.pyx conflicts with #20767. Please just remove all changes to that file (or at least make sure that it doesn't conflict).
comment:3 Changed 6 years ago by
| Commit: | c0524a494e946af350be158c48f757db17024e90 → 0e462b8b24373acbd392db57f7e775f7e87ea614 |
|---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
| 0e462b8 | start handling removed attributes func_* and im_*
|
comment:5 Changed 6 years ago by
| Status: | new → needs_review |
|---|
comment:6 Changed 6 years ago by
Please don't change src/sage_setup/docbuild/ext/sage_autodoc.py. It should be treated as a file coming from upstream.
comment:7 Changed 6 years ago by
| Commit: | 0e462b8b24373acbd392db57f7e775f7e87ea614 → 248adb2d4cae7da6f472b20eaff7dff45921eecc |
|---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
| 248adb2 | start handling removed attributes func_* and im_*
|
comment:9 Changed 6 years ago by
| Reviewers: | → Jeroen Demeyer |
|---|
positive_review if this passes doctests.
comment:10 Changed 6 years ago by
| Commit: | 248adb2d4cae7da6f472b20eaff7dff45921eecc → f635fba17d7146e4990b1121d978b1c12ee2dc1a |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| f635fba | trac 21250 missing future import
|
comment:11 Changed 6 years ago by
| Status: | needs_review → needs_work |
|---|
sage -t src/sage/misc/rest_index_of_methods.py # 1 doctest failed
comment:12 Changed 6 years ago by
| Commit: | f635fba17d7146e4990b1121d978b1c12ee2dc1a → 53ada4539978b91c61ae2622d27ce64c8747f067 |
|---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
| 53ada45 | start handling removed attributes func_* and im_*
|
comment:13 Changed 6 years ago by
| Status: | needs_work → positive_review |
|---|
ok, here is a branch where I have just reverted the changes in one file. This branch passes all doctests, so I will assume that I can put it to positive review in your name.
comment:14 Changed 6 years ago by
| Branch: | u/chapoton/21250 → 53ada4539978b91c61ae2622d27ce64c8747f067 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
start handling removed attributes func_* and im_*