Opened 6 years ago
Closed 6 years ago
#21414 closed enhancement (fixed)
py3: remove one cmp in matrix2
| Reported by: | Frédéric Chapoton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-7.4 |
| Component: | python3 | Keywords: | |
| Cc: | Travis Scrimshaw, Jeroen Demeyer, aapitzsch | Merged in: | |
| Authors: | Frédéric Chapoton | Reviewers: | André Apitzsch |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 700320e (Commits, GitHub, GitLab) | Commit: | 700320e17544b36ef34f0212fad9b825450fa646 |
| Dependencies: | Stopgaps: |
Status badges
Description
as a step to py3, let us use a key to sort, not cmp
Change History (3)
comment:1 Changed 6 years ago by
| Branch: | → public/21414 |
|---|---|
| Cc: | Travis Scrimshaw Jeroen Demeyer aapitzsch added |
| Commit: | → 700320e17544b36ef34f0212fad9b825450fa646 |
| Component: | PLEASE CHANGE → python3 |
| Status: | new → needs_review |
comment:2 Changed 6 years ago by
| Reviewers: | → André Apitzsch |
|---|---|
| Status: | needs_review → positive_review |
| Type: | PLEASE CHANGE → enhancement |
I think it doesn't matter whether it's list.sort(v) or v.sort(); that's why positive review.
comment:3 Changed 6 years ago by
| Branch: | public/21414 → 700320e17544b36ef34f0212fad9b825450fa646 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
easy little ticket
New commits:
convert one comparison to use key (in matrix2)