Opened 4 years ago

Closed 4 years ago

#21890 closed enhancement (fixed)

add strongly regular (196,60,14,20)-graph to the database of SRGs

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.0
Component: graph theory Keywords:
Cc: dcoudert, vdelecroix Merged in:
Authors: Dima Pasechnik Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f0e1829 (Commits) Commit: f0e18290cc91018841820bb335ffa9b4d5f607e9
Dependencies: #21155 Stopgaps:

Description

This is constructed in Tayuan Huang, Lingling Huang & Miaow-Ing Lin, On a class of strongly regular designs and quasi-semisymmetric designs, Recent Developments in Algebra and Related Areas: ALM 8, pp. 129–153

Change History (18)

comment:1 Changed 4 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/hhl09
  • Commit set to f9d1c4afcac22ff14129b6c70f877ce8a4e9b299
  • Work issues set to figure out formula for parameters

New commits:

​f9d1c4aimplemented Brouwer's construction

comment:2 Changed 4 years ago by git

  • Commit changed from f9d1c4afcac22ff14129b6c70f877ce8a4e9b299 to 9e7a4cf0419b27330c756370bd5e7736c211aeb6

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​e751532Merge branch 'u/dimpase/muzS6' of trac.sagemath.org:sage into muz61
​f6d862fremoved broken user-supplied Sigma dict parameter;
​66b5648Merge branch 'muz61' into muzS6bis
​b6a169ffix a typo mentioned on #21061
​12ed381added EPSRC ackn. for Rowan
​df0c845Merge branch 'u/dimpase/muzS6' of trac.sagemath.org:sage into iokar
​2c74c1ebackslash!
​b9a96c0Merge branch 'develop' into muz
​25bef77implemented reviewer's suggestions
​9e7a4cfMerge branch 'u/dimpase/hhl09' of trac.sagemath.org:sage into muz

comment:3 Changed 4 years ago by dimpase

  • Dependencies set to #21155

comment:4 Changed 4 years ago by git

  • Commit changed from 9e7a4cf0419b27330c756370bd5e7736c211aeb6 to ed3876f811bc10b9bea210b1cf1105ad892cf141

Branch pushed to git repo; I updated commit sha1. New commits:

​ed3876fadded recognition function

comment:5 Changed 4 years ago by dimpase

  • Status changed from new to needs_review

comment:6 Changed 4 years ago by dimpase

  • Cc dcoudert added

comment:7 Changed 4 years ago by dimpase

  • Cc vdelecroix added
  • Work issues figure out formula for parameters deleted

comment:8 Changed 4 years ago by dimpase

patchbot coverage plugin complains here about something not relevant to this ticket/branch. And, by the way, there is also now #21889 ready for review, depending on this ticket...

comment:9 Changed 4 years ago by dimpase

timeouts on the bot are irrelevant, caused by giac.

comment:10 Changed 4 years ago by dimpase

  • Milestone changed from sage-7.5 to sage-7.6

patchbot says 

----------------------------------------------------------------------
sage -t --long src/sage/groups/perm_gps/permgroup_named.py  # Timed out
sage -t --long src/sage/modular/abvar/abvar.py  # Timed out

but this is certainly nothing to worry about.

comment:11 Changed 4 years ago by dimpase

  • Milestone changed from sage-7.6 to sage-8.0

a startup plugin failing, but otherwise (sane) patchbots are happy.

comment:12 Changed 4 years ago by tscrim

Some small tweaks:

  • Period missing at the end of the 1-line description.
  • ..math:: -> .. MATH::.
  • <v,o_1> -> \langle v, o_1 \rangle (and similar).

comment:13 Changed 4 years ago by git

  • Commit changed from ed3876f811bc10b9bea210b1cf1105ad892cf141 to f0e18290cc91018841820bb335ffa9b4d5f607e9

Branch pushed to git repo; I updated commit sha1. New commits:

​3ea7f99Merge branch 'u/dimpase/hhl09' of trac.sagemath.org:sage into t21890fix
​f0e1829fixed typos noticed by the reviewer

comment:14 Changed 4 years ago by dimpase

fixed, please have another look.

comment:15 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks, LGTM.

comment:16 Changed 4 years ago by dimpase

Thanks a a lot. It's hard to find people to review...

comment:17 Changed 4 years ago by dcoudert

Sorry for not helping reviewing this ticket, but I'm not confident with this kind of construction.

comment:18 Changed 4 years ago by vbraun

  • Branch changed from u/dimpase/hhl09 to f0e18290cc91018841820bb335ffa9b4d5f607e9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.