Opened 5 years ago

Closed 5 years ago

#22423 closed defect (fixed)

Random failure in sagenb/storage/filesystem_storage.py

Reported by: vbraun Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords: random_fail
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description 

sage -t --long local/lib/python2.7/site-packages/sagenb/storage/filesystem_storage.py
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb/storage/filesystem_storage.py", line 183, in sagenb.storage.filesystem_storage.FilesystemDatastore._save
Failed example:
    try:  # long time
        alarm(1)
        while True:
            D._save(s, fn)
    except (AlarmInterrupt, OSError):
        # OSError could happen due to a double close() in
        # Python's tempfile module.
        pass
Expected nothing
Got:
    Exception AttributeError: "'file' object has no attribute 'close_called'" in <bound method _TemporaryFileWrapper.__del__ of <open file '<fdopen>', mode 'w+b' at 0x272406c90>> ignored
    close failed in file object destructor:
    IOError: [Errno 9] Bad file descriptor
**********************************************************************
1 item had failures:
   1 of   8 in sagenb.storage.filesystem_storage.FilesystemDatastore._save
    [46 tests, 1 failure, 2.07 s]

Clearly the signal arrived during the TemporaryFile constructor...

Change History (1)

comment:1 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Milestone changed from sage-7.6 to sage-duplicate/invalid/wontfix
  • Resolution set to fixed
  • Status changed from new to closed

See ​https://github.com/sagemath/sagenb/commit/f987c9c0e1003916bb37a7791936a14bfe75beff

Note: See TracTickets for help on using tickets.