Opened 5 years ago

Closed 5 years ago

#22662 closed enhancement (fixed)

Fold farey.pxd into farey_symbol.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: cython Keywords:
Cc: embray Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8e5db1e (Commits, GitHub, GitLab) Commit: 8e5db1e2dccb61de366439d6da285b56a14f4d9c
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Unlike other .pxd files, the file farey.pxd is not meant as public header. For this reason, we move its contents to the file farey_symbol.pyx, which is the only place where it is used.

We also fix a typo __deallocpp__ causing a memory leak.

Change History (10)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/22662

comment:3 Changed 5 years ago by jdemeyer

  • Commit set to 1dd577194a4aa73d7366e2a6a4b5b97d3b06ee00
  • Status changed from new to needs_review

New commits:

​1dd5771Fold farey.pxd into farey_symbol.pyx

comment:4 follow-up: Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work 
sage -t --long src/sage_setup/find.py  # 1 doctest failed

comment:5 Changed 5 years ago by git

  • Commit changed from 1dd577194a4aa73d7366e2a6a4b5b97d3b06ee00 to 8e5db1e2dccb61de366439d6da285b56a14f4d9c

Branch pushed to git repo; I updated commit sha1. New commits:

​8e5db1eChange test

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:7 Changed 5 years ago by jdemeyer

  • Cc embray added

comment:8 in reply to: ↑ 4 Changed 5 years ago by jdemeyer

Replying to chapoton: 

sage -t --long src/sage_setup/find.py  # 1 doctest failed

Fixed, patchbot looks good now.

comment:9 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/22662 to 8e5db1e2dccb61de366439d6da285b56a14f4d9c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.