Opened 4 years ago

Closed 4 years ago

#22893 closed enhancement (fixed)

unicode art for chain complexes

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.0
Component: algebraic topology Keywords:
Cc: jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: f424fed (Commits, GitHub, GitLab) Commit: f424fed0f4d5382144c05aba115a6d8a2e5bf195
Dependencies: Stopgaps:

Status badges

Description

just for the beauty of it

Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22893
  • Cc jhpalmieri added
  • Commit set to 01fe73e4013fb7d4c74189feaccc5e4280fb5a80
  • Status changed from new to needs_review

New commits:

​01fe73eunicode art for chain complexes

comment:2 Changed 4 years ago by jhpalmieri

Looks nice but I get a few doctest failures in the file chains.py.

comment:3 Changed 4 years ago by git

  • Commit changed from 01fe73e4013fb7d4c74189feaccc5e4280fb5a80 to a730fdf3986a502451218e6ae6de4a63cbc8e500

Branch pushed to git repo; I updated commit sha1. New commits:

​ea7462fMerge branch 'u/chapoton/22893' in 8.0.b4
​a730fdftrac 22893 change back ascii art of chain complexes to previous code

comment:4 Changed 4 years ago by chapoton

I undid the change I made to the ascii art.

comment:5 Changed 4 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks nice!

comment:6 Changed 4 years ago by jhpalmieri

  • Branch changed from u/chapoton/22893 to u/jhpalmieri/22893

comment:7 Changed 4 years ago by jhpalmieri

  • Commit changed from a730fdf3986a502451218e6ae6de4a63cbc8e500 to f424fed0f4d5382144c05aba115a6d8a2e5bf195

Oh, I fixed a typo/grammar issue (twice).

New commits:

​f424fedtrac 22893: fix typo

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jhpalmieri/22893 to f424fed0f4d5382144c05aba115a6d8a2e5bf195
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.