Opened 4 years ago

Closed 4 years ago

#23532 closed defect (fixed)

Update links in Three.js examples

Reported by: paulmasson Owned by:
Priority: minor Milestone: sage-8.1
Component: documentation Keywords:
Cc: Merged in:
Authors: Paul Masson Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: daf5832 (Commits, GitHub, GitLab) Commit: daf58320a7aa95a0ad4cd24b1e5ab2d8a924e04c
Dependencies: Stopgaps:

Status badges

Description


Change History (5)

comment:1 Changed 4 years ago by paulmasson

  • Branch set to u/paulmasson/update_links_in_three_js_examples

comment:2 Changed 4 years ago by paulmasson

  • Authors set to Paul Masson
  • Commit set to daf58320a7aa95a0ad4cd24b1e5ab2d8a924e04c
  • Component changed from PLEASE CHANGE to documentation
  • Priority changed from major to minor
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

The links in these examples are incorrectly pointing to files on my local computer and have been updated to point to the CDN.

New commits:

​daf5832Update links

comment:3 Changed 4 years ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to needs_info

Does not work for me: having pulled the ticket branch into Sage 8.1.beta0 and run make, I still get blank boxes in the Three.js JavaScript WebGL Renderer section of the reference manual. Besides, if I open directly the file src/doc/en/reference/plot3d/threejs_examples/spheres.html in my browser, I get a blank box as well.

comment:4 Changed 4 years ago by egourgoulhon

  • Status changed from needs_info to positive_review

Having run make doc-clean && make and cleared the cache of my browser, it works now.

Thanks for this fix!

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/paulmasson/update_links_in_three_js_examples to daf58320a7aa95a0ad4cd24b1e5ab2d8a924e04c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.