Opened 5 years ago
Closed 5 years ago
#23966 closed defect (fixed)
Conversion from ZpFM to its fraction field incorrect
Reported by: | Julian Rüth | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | padics | Keywords: | |
Cc: | David Roe | Merged in: | |
Authors: | David Roe | Reviewers: | Julian Rüth |
Report Upstream: | N/A | Work issues: | |
Branch: | b8de189 (Commits, GitHub, GitLab) | Commit: | b8de18928c9d5ec2e4aade83ab910e97673191d4 |
Dependencies: | #23510 | Stopgaps: |
Description
sage: R = ZqFM(2) sage: K = R.fraction_field() sage: K(R.zero()) <blankline>
Change History (8)
comment:1 Changed 5 years ago by
Branch: | → u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect |
---|
comment:2 Changed 5 years ago by
Authors: | → Julian Rüth |
---|---|
Branch: | u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect |
Cc: | David Roe added |
Status: | new → needs_review |
comment:3 Changed 5 years ago by
Branch: | → u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect |
---|---|
Commit: | → 87c900cc682f0d52c7bc6e3ef23f466eba373939 |
comment:4 Changed 5 years ago by
Branch: | u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect → u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect |
---|
comment:5 Changed 5 years ago by
Authors: | Julian Rüth → David Roe |
---|---|
Commit: | 87c900cc682f0d52c7bc6e3ef23f466eba373939 → b8de18928c9d5ec2e4aade83ab910e97673191d4 |
Reviewers: | → Julian Rüth |
Alright, I've taken a different approach, and added in a test.
Last 10 new commits:
cb882fd | Update add_bigoh to account for fixed-mod having a fraction field
|
a826978 | Fix _tester_add_bigoh
|
883e6b5 | Fix doctest in local_generic_element.pyx
|
52cbd2a | Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
bc59ffa | Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
|
3292259 | Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
dad02c7 | Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
189ac2b | Add _test_fraction_field to the coercion tutorial
|
98d8256 | Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into develop
|
b8de189 | Different fix for 23966, add doctest
|
comment:6 Changed 5 years ago by
Dependencies: | → #23510 |
---|
Most of the changes visible are from #23510. This ticket is basically the changes to FP_template.pxi
.
comment:7 Changed 5 years ago by
Status: | needs_review → positive_review |
---|
there is one failing doctest from the patchbot which should be unrelated.
comment:8 Changed 5 years ago by
Branch: | u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect → b8de18928c9d5ec2e4aade83ab910e97673191d4 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
David, you know this code much better than I do. I have no idea if this is the best fix for this.