Opened 3 years ago

Closed 3 years ago

#24583 closed defect (duplicate)

py3: additional fixes to sage.interfaces

Reported by: embray Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers:
Report Upstream: N/A Work issues:
Branch: u/embray/python3/sage-interfaces (Commits, GitHub, GitLab) Commit: d169089100381f19af40476b075e9c65d3e7bcc5
Dependencies: #24269 Stopgaps:

Status badges

Description

In #24269 I made some initial fixes to sage.interfaces just to get a minimum of functionality working.

This adds on top of that some additional fixes to sage.interfaces.interface and sage.interfaces.expect that were needed in getting the rest of the sage.interfaces tests passing.

I'll follow up with additional tickets with fixes for the program-specific interfaces.

Change History (6)

comment:1 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit changed from bd6a3315b77df272b07e3d646cec0a54b9d77b69 to 2181b3eba6114f902f3599dbb76ad7d068478520

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​afb7643Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​2181b3epy3: additional minor str/bytes fixes to the sage.interfaces framework

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 Changed 3 years ago by embray

  • Status changed from needs_review to needs_work

This probably needs to be rebased on current #24269

comment:5 Changed 3 years ago by git

  • Commit changed from 2181b3eba6114f902f3599dbb76ad7d068478520 to d169089100381f19af40476b075e9c65d3e7bcc5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​3f08a18Also supply a wrapper around spawn.readline that incorporates bytes_to_str
​6c8a6f0Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​4a6a72ajust pyflakes fix
​3d4bcc5undo import removal
​25409dcthe base class now provides the expectation that self._prompt is already bytes
​d169089Additional Python 3 fixes to the Maxima interface:

comment:6 Changed 3 years ago by embray

  • Milestone changed from sage-8.3 to sage-duplicate/invalid/wontfix
  • Resolution set to duplicate
  • Status changed from needs_work to closed

Apparently all that's left of this ticket that isn't already merged is a few more minor fixes for the maxima interface, so I'll just add that to #24269 and close this ticket.

New commits:

​3f08a18Also supply a wrapper around spawn.readline that incorporates bytes_to_str
​6c8a6f0Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​4a6a72ajust pyflakes fix
​3d4bcc5undo import removal
​25409dcthe base class now provides the expectation that self._prompt is already bytes
​d169089Additional Python 3 fixes to the Maxima interface:
Note: See TracTickets for help on using tickets.