Opened 4 years ago
Closed 4 years ago
#26554 closed enhancement (fixed)
improve boost_graph.pyx
| Reported by: | David Coudert | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.5 |
| Component: | graph theory | Keywords: | py3, graph |
| Cc: | Travis Scrimshaw, Frédéric Chapoton, John Palmieri | Merged in: | |
| Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 71fa004 (Commits, GitHub, GitLab) | Commit: | 71fa004c35f2814a7fd5824ef867432aab28c1d3 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Improve the boost graph interface to avoid using .vertices().
After that, *one* sorted operation involving vertex labels comparisons remains, in method min_spanning_tree.
Change History (8)
comment:1 Changed 4 years ago by
| Branch: | → public/26554_boost_graph_pyx |
|---|---|
| Cc: | Travis Scrimshaw Frédéric Chapoton added |
| Commit: | → 4cb7735f850d0762940bc364bd09bb829d9b82c0 |
| Description: | modified (diff) |
| Status: | new → needs_review |
comment:2 Changed 4 years ago by
The patchbot reports two failures that are likely caused from this patch (I cannot check right now):
sage -t --long src/sage/homology/simplicial_complex.py # 2 doctests failed sage -t --long src/sage/matroids/utilities.py # 1 doctest failed
comment:3 Changed 4 years ago by
| Commit: | 4cb7735f850d0762940bc364bd09bb829d9b82c0 → 71fa004c35f2814a7fd5824ef867432aab28c1d3 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 71fa004 | trac #26554: correct failing doctests in simplicial_complex and matroids
|
comment:4 Changed 4 years ago by
I have corrected the doctests, but it would be good if someone could check that the results are effectively correct. I have no doubt in src/sage/matroids/utilities.py as the output of a test taking as input the changed matrix is unchanged. I have more difficulty with simplicial_complex...
comment:5 Changed 4 years ago by
| Cc: | John Palmieri added |
|---|---|
| Reviewers: | → Travis Scrimshaw |
| Status: | needs_review → positive_review |
The changes to simplicial_complex.py are trivially equivalent (same presentation of groups except for the generator names). I am very mildly worried that the output may not always be consistent, but since we are in such early beta stages, I think getting this in and testing it will be the best way.
John, I am cc-ing you to also note this ticket in case we do start seeing random failures in simplicial_complex.py.
comment:8 Changed 4 years ago by
| Branch: | public/26554_boost_graph_pyx → 71fa004c35f2814a7fd5824ef867432aab28c1d3 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
This one took me some time as error messages of Cython are sometimes hard to understand...
New commits:
trac #26554: improve boost_graph.pyx