Opened 2 years ago

Closed 2 years ago

#27510 closed enhancement (fixed)

fix some pyflakes warning in matrix groups

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: refactoring Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f6d0bfe (Commits, GitHub, GitLab) Commit: f6d0bfee3232e3943e12914285879fc1675ec87e
Dependencies: Stopgaps:

Status badges

Description

some unused variables and imports

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27510
  • Commit set to 27fd88e10518d1f68ac0ff2d263da0396daec865
  • Status changed from new to needs_review

New commits:

​27fd88efix some pyflakes warnings in matrix groups

comment:2 Changed 2 years ago by git

  • Commit changed from 27fd88e10518d1f68ac0ff2d263da0396daec865 to f6d0bfee3232e3943e12914285879fc1675ec87e

Branch pushed to git repo; I updated commit sha1. New commits:

​f6d0bfeadd back the singular ring assignement

comment:3 Changed 2 years ago by chapoton

  • Cc tscrim added

ok, green bot, please review

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27510 to f6d0bfee3232e3943e12914285879fc1675ec87e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.