Opened 3 years ago
Closed 3 years ago
#28212 closed enhancement (duplicate)
Optimizing all_periodic_points() for small periods
| Reported by: | Eric Zhu | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | dynamics | Keywords: | SI2019, sd104 |
| Cc: | Merged in: | ||
| Authors: | Eric Zhu, Alex Galarraga, Bianca Thompson | Reviewers: | Ben Hutz |
| Report Upstream: | N/A | Work issues: | |
| Branch: | u/gh-Zopherus/28212 (Commits, GitHub, GitLab) | Commit: | 6b8b99c5ac78dacede53dffbc65a7340d70eb2f1 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Currently, the all_periodic_points() method uses an algorithm that reduces the function modulo p and checks for possible cycle lengths and lifts. This method may be slow in certain cases, such as x2 - 3/4, where we resort to calling the periodic_points() method which solves for the dynatomic polynomial.
Change History (8)
comment:1 Changed 3 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 3 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 3 years ago by
| Branch: | → u/gh-Zopherus/28212 |
|---|
comment:4 Changed 3 years ago by
| Commit: | → 6b8b99c5ac78dacede53dffbc65a7340d70eb2f1 |
|---|---|
| Status: | new → needs_review |
comment:5 Changed 3 years ago by
This ticket depends on ticket #28109 so it needs to be added to dependencies.
comment:6 Changed 3 years ago by
| Milestone: | sage-8.9 → sage-duplicate/invalid/wontfix |
|---|---|
| Reviewers: | → Ben Hutz |
This optimization is already done in #28109 as part of the major overhaul of the periodic point functionality.
comment:7 Changed 3 years ago by
| Keywords: | sd104 added |
|---|---|
| Status: | needs_review → positive_review |
comment:8 Changed 3 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
Merge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109Added method to cython helperMerge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109added C code to all_periodic_points()Merge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109added documentation and deprecated rational_periodic_pointsFinished depreciationAdded optional parameter for base ringdelete print statementAdded check to do dynatomic method