Opened 2 years ago

Closed 17 months ago

#29811 closed enhancement (fixed)

PolyhedronFace: Add method to compute affine tangent cones

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: Jean-Philippe Labbé, gh-kliem, Michael Orlitzky, Yuan Zhou, Travis Scrimshaw Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 5965400 (Commits, GitHub, GitLab) Commit: 5965400139f4ff4e3a589a2d71ad8ff3674d87b1
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

In analogy to the existing method normal_cone.

For #29806 (Gram-Brianchon formula) I only need the (affine) tangent cones of a face, tcone(P, F). See for example https://epubs.siam.org/doi/pdf/10.1137/1.9781611972443.ch6 Def 6.2.2

Change History (12)

comment:1 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:2 Changed 2 years ago by Michael Orlitzky

Cc: Michael Orlitzky added

comment:3 Changed 22 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:4 Changed 19 months ago by Matthias Köppe

Cc: Yuan Zhou added

comment:5 Changed 18 months ago by Matthias Köppe

Authors: Matthias Koeppe
Description: modified (diff)
Summary: PolyhedronFace: Add methods to compute cones of feasible directions and affine tangent conesPolyhedronFace: Add method to compute affine tangent cones

comment:6 Changed 18 months ago by Matthias Köppe

Branch: u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones

comment:7 Changed 18 months ago by Matthias Köppe

Commit: 5965400139f4ff4e3a589a2d71ad8ff3674d87b1
Status: newneeds_review

New commits:

5965400PolyhedronFace.affine_tangent_cone: New

comment:8 Changed 18 months ago by Matthias Köppe

Patchbot is green modulo the unrelated misc/package failure

comment:9 Changed 17 months ago by Matthias Köppe

Cc: Travis Scrimshaw added

comment:10 Changed 17 months ago by gh-kliem

Status: needs_reviewpositive_review

LGTM.

comment:11 Changed 17 months ago by Matthias Köppe

Reviewers: Jonathan Kliem

Thanks!

comment:12 Changed 17 months ago by Volker Braun

Branch: u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones5965400139f4ff4e3a589a2d71ad8ff3674d87b1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.