Opened 22 months ago

Closed 22 months ago

#30129 closed defect (fixed)

Fix broken test for SAGE_ROOT from #29111

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.2
Component: scripts Keywords:
Cc: mkoeppe, jhpalmieri, fbissey Merged in:
Authors: Antonio Rojas Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 5cb5ac8 (Commits, GitHub, GitLab) Commit: 5cb5ac811d43bbd262a204b120d92af32d06cca2
Dependencies: Stopgaps:

Status badges

Description (last modified by arojas)

[ -n "$SAGE_ROOT/" ] is always true because of the trailing slash. This causes two test failures on distro packages.

Change History (4)

comment:1 Changed 22 months ago by arojas

  • Branch set to u/arojas/fix_testing_for_sage_root

comment:2 Changed 22 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc mkoeppe jhpalmieri fbissey added
  • Commit set to 5cb5ac811d43bbd262a204b120d92af32d06cca2
  • Component changed from PLEASE CHANGE to scripts
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Fix testing for SAGE_ROOT to Fix broken test for SAGE_ROOT from #29111
  • Type changed from PLEASE CHANGE to defect

New commits:

​5cb5ac8Fix testing for SAGE_ROOT

comment:3 Changed 22 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:4 Changed 22 months ago by vbraun

  • Branch changed from u/arojas/fix_testing_for_sage_root to 5cb5ac811d43bbd262a204b120d92af32d06cca2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.