Opened 21 months ago

Closed 21 months ago

#30429 closed enhancement (fixed)

Standardize `intersection` in `combinatorial_polyhedron/bit_vector_operations.cc`

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-9.2
Component: geometry Keywords:
Cc: jipilab, gh-LaisRast, tscrim Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fe880a4 (Commits, GitHub, GitLab) Commit: fe880a4d5422617f4b15d0b0c36838db3c7fe9b4
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

We standardize the arguments of the intersection to be 

inline void intersection(uint64_t *dest uint64_t *A uint64_t *B, size_t face_length)

corresponding well with C[i] = A[i] & B[i] (and with src/sage/data_structures/bitset.pxi).

Previously it was 

inline void intersection(uint64_t *A, uint64_t *B, uint64_t *C, size_t face_length)

This is confusing, once you get used to the standard way of doing it (gmp also has mpz_add(mpz_t dest, const mpz_t src1, const mpz_t src2))

Change History (8)

comment:1 Changed 21 months ago by gh-kliem

  • Description modified (diff)

comment:2 Changed 21 months ago by gh-kliem

  • Description modified (diff)

comment:3 Changed 21 months ago by gh-kliem

  • Cc public/30429 added
  • Status changed from new to needs_review

comment:4 Changed 21 months ago by gh-kliem

  • Branch set to public/30429
  • Cc jipilab gh-LaisRast added; public/30429 removed
  • Commit set to fe880a4d5422617f4b15d0b0c36838db3c7fe9b4

New commits:

​fe880a4input of `intersection` in standard order

comment:5 Changed 21 months ago by mkoeppe

  • Cc tscrim added

comment:6 Changed 21 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 21 months ago by gh-kliem

Thank you.

comment:8 Changed 21 months ago by vbraun

  • Branch changed from public/30429 to fe880a4d5422617f4b15d0b0c36838db3c7fe9b4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.