Opened 23 months ago
Closed 23 months ago
#31243 closed enhancement (fixed)
Stronger Categories for Manifold Examples: Connectedness
| Reported by: | Michael Jung | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.3 |
| Component: | manifolds | Keywords: | |
| Cc: | Eric Gourgoulhon, Travis Scrimshaw | Merged in: | |
| Authors: | Michael Jung | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 440bc50 (Commits, GitHub, GitLab) | Commit: | 440bc5053d601a29538ac1640729f3719abe8932 |
| Dependencies: | #31233 | Stopgaps: |
Status badges
Description (last modified by )
Currently, an instance of OpenInterval just belongs to the category of smooth manifolds even though it is also connected. Similarly for Euclidean spaces and spheres.
The category of connected manifolds will be joined.
Part of metaticket #30189.
Change History (16)
comment:1 Changed 23 months ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 23 months ago by
| Branch: | → u/gh-mjungmath/stronger_categories_manifolds_examples |
|---|
comment:3 Changed 23 months ago by
| Commit: | → 81a94a550ce71b638af365b3f7f2e82708c77234 |
|---|---|
| Status: | new → needs_review |
comment:4 Changed 23 months ago by
| Commit: | 81a94a550ce71b638af365b3f7f2e82708c77234 → c3c7ff0b05eb1d36c011bebfd4579fdb99a9a938 |
|---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
| c3c7ff0 | Trac #31243: examples added to category of connected manifolds
|
comment:5 Changed 23 months ago by
| Dependencies: | → #31233 |
|---|
comment:6 Changed 23 months ago by
| Commit: | c3c7ff0b05eb1d36c011bebfd4579fdb99a9a938 → 1483634cf5d6084698482ec417dbcb8e57358b6c |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| be52d78 | Trac #31233: meet categories
|
| 78f7af3 | Trac #31233: category of homset docstring adapted
|
| 8d31e0f | Trac #31233: fixing format
|
| 111015d | Trac #31233: adapt homsets in docstring
|
| 68de9c9 | Merge branch 't/31233/categories_for_homset_of_manifolds_do_not_meet' into stronger_categories_manifolds_examples
|
| 1483634 | Trac #31243: doctest conflicts with #31233
|
comment:7 follow-up: 9 Changed 23 months ago by
It would be easier just to call the Connected() on the category:
- category = Manifolds(RR).Smooth() & Manifolds(RR).Connected() + category = Manifolds(RR).Smooth().Connected()
- TopologicalSpaces().Compact() & Manifolds(RR).Connected() + TopologicalSpaces().Compact().Connected()
comment:8 Changed 23 months ago by
| Commit: | 1483634cf5d6084698482ec417dbcb8e57358b6c → 7f0de49bcd13308928238a598122b0995749fbee |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 7f0de49 | Trac #31243: doctest missed
|
comment:9 Changed 23 months ago by
Replying to tscrim:
It would be easier just to call the
Connected()on the category:- category = Manifolds(RR).Smooth() & Manifolds(RR).Connected() + category = Manifolds(RR).Smooth().Connected()- TopologicalSpaces().Compact() & Manifolds(RR).Connected() + TopologicalSpaces().Compact().Connected()
Indeed.
comment:10 Changed 23 months ago by
| Commit: | 7f0de49bcd13308928238a598122b0995749fbee → 22df7718f71eb2a323bdf7e4838635c87b0b7edd |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 22df771 | Trac #31241: call categories more comfortable + rearranged category order in doctest
|
comment:12 Changed 23 months ago by
| Commit: | 22df7718f71eb2a323bdf7e4838635c87b0b7edd → 440bc5053d601a29538ac1640729f3719abe8932 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 440bc50 | Trac #31243: categories adapted in tutorial
|
comment:14 Changed 23 months ago by
| Reviewers: | → Travis Scrimshaw |
|---|---|
| Status: | needs_review → positive_review |
comment:16 Changed 23 months ago by
| Branch: | u/gh-mjungmath/stronger_categories_manifolds_examples → 440bc5053d601a29538ac1640729f3719abe8932 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
Trac #31243: examples added to category of connected manifolds