Opened 17 months ago

Closed 17 months ago

#32257 closed defect (fixed)

Cygwin patch for Singular

Reported by: Matthias Köppe Owned by:
Priority: blocker Milestone: sage-9.4
Component: packages: standard Keywords:
Cc: Volker Braun, Dima Pasechnik, Samuel Lelièvre Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik, Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: d4156f7 (Commits, GitHub, GitLab) Commit: d4156f754ca211962bd58057a547a1c726d60e33
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

As noted in ​https://trac.sagemath.org/ticket/32001#comment:1, pynac fails on cygwin-standard. We add a patch to singular to fix this

​https://github.com/Singular/Singular/pull/1109 (merged)

Change History (8)

comment:1 Changed 17 months ago by Matthias Köppe

Reviewers: → https://github.com/mkoeppe/sage/actions/runs/1051039345

comment:2 Changed 17 months ago by Matthias Köppe

Description: modified (diff)

comment:3 Changed 17 months ago by Matthias Köppe

Branch: → u/mkoeppe/cygwin_patch_for_singular

comment:4 Changed 17 months ago by Matthias Köppe

Authors: → Matthias Koeppe
Cc: Volker Braun Dima Pasechnik Samuel Lelièvre added
Commit: → d4156f754ca211962bd58057a547a1c726d60e33
Description: modified (diff)
Status: new → needs_review

This does the job.

New commits:

​d4156f7build/pkgs/singular/patches/0001-factory-canonicalform.h-Add-more-FACTORY_PUBLIC.patch: New

comment:5 Changed 17 months ago by Dima Pasechnik

Reviewers: https://github.com/mkoeppe/sage/actions/runs/1051039345 → Dima Pasechnik
Status: needs_review → positive_review

OK, great.

comment:6 Changed 17 months ago by Samuel Lelièvre

Reviewers: Dima Pasechnik → Dima Pasechnik, Samuel Lelièvre

I applied this locally on Cygwin on Windows 10. It works and makes #32001 work.

I'm curious how you figured out those changes would solve this problem! Thank you!

comment:7 Changed 17 months ago by Matthias Köppe

Thanks for testing! The fix was just an extension of one that Hans Schoenemann did earlier this year to get Cygwin working.

comment:8 Changed 17 months ago by Volker Braun

Branch: u/mkoeppe/cygwin_patch_for_singular → d4156f754ca211962bd58057a547a1c726d60e33
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.