Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3336 closed enhancement (fixed)

[with patch, positive review] DyckWords(n) should use an iterator

Reported by: ddrake Owned by: ddrake
Priority: major Milestone: sage-3.0.3
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Currently, DyckWords?(n) creates a list, which uses a lot of memory and is slow. See ​this sage-devel thread.

Attachments (1)

dyckword-3336.patch​ (7.8 KB) - added by ddrake 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by ddrake

  • Summary changed from DyckWords(n) should use an iterator to [with patch, needs review] DyckWords(n) should use an iterator

Patch attached.

Changed 7 years ago by ddrake

comment:2 Changed 7 years ago by mhansen

  • Summary changed from [with patch, needs review] DyckWords(n) should use an iterator to [with patch, positive review] DyckWords(n) should use an iterator

Looks good. Thanks for this Dan! I also added it to 2144.

comment:3 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.3.alpha1

comment:4 Changed 6 years ago by nthiery

  • Cc sage-combinat added
Note: See TracTickets for help on using tickets.