Opened 7 months ago

Closed 7 months ago

#33755 closed defect (fixed)

GH Actions (macos): Fix test of optional/experimental packages

Reported by: Matthias Köppe Owned by:
Priority: blocker Milestone: sage-9.6
Component: porting Keywords:
Cc: John Palmieri, gh-kliem, Dima Pasechnik Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 60adee6 (Commits, GitHub, GitLab) Commit: 60adee640c3ba76a8a57c63152cd3eab70ffa660
Dependencies: Stopgaps:

Status badges

Description

These tests are currently not being run because of a bug in the script - see https://github.com/sagemath/sage/runs/6085026418?check_suite_focus=true:

Run case "2-optional-0-o" in
  case "2-optional-0-o" in
[...]
    2-optional*)     export TARGETS_PRE="build/make/Makefile" TARGETS="build/make/Makefile"
                     targets_pattern="2-optional-0-o"
                     targets_pattern="${targets_pattern#2-optional-}"
                     export TARGETS_OPTIONAL=$( echo $(export PATH=build/bin:$PATH && (for a in spkg-install.in spkg-install requirements.txt; do sage-package list :optional: --has-file $a --no-file huge --no-file has_nonfree_dependencies; done) | grep -v ^_ | grep -v sagemath_doc | grep '^[]' ) )
                     ;;
[...]
  esac
  MAKE="make -j12" tox -e $TOX_ENV -- SAGE_NUM_THREADS=4 $TARGETS

grep: brackets ([ ]) not balanced

Change History (12)

comment:1 Changed 7 months ago by Matthias Köppe

Last touched in #33140, #29919

comment:2 Changed 7 months ago by Matthias Köppe

Branch: u/mkoeppe/gh_actions__macos___fix_test_of_optional_experimental_packages

comment:3 Changed 7 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 60adee640c3ba76a8a57c63152cd3eab70ffa660

New commits:

60adee6.github/workflows/tox.yml: Fix test of optional/experimental packages

comment:4 Changed 7 months ago by Matthias Köppe

Reviewers: https://github.com/mkoeppe/sage/actions/runs/2218172551
Status: newneeds_review

comment:5 Changed 7 months ago by Matthias Köppe

Cc: gh-kliem Dima Pasechnik added

The tests run now, needs review.

comment:6 Changed 7 months ago by Dima Pasechnik

I see

Run brew install tox
==> Downloading https://ghcr.io/v2/homebrew/core/six/manifests/1.16.0_2-1
curl: (22) The requested URL returned error: 503 
Error: tox: Failed to download resource "six_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/six/manifests/1.16.0_2-1
Error: Process completed with exit code 1.

Trying to open this URL in browser gives

{"errors":[{"code":"UNAUTHORIZED","message":"authentication required"}]}

By the way, there is also something wrong with "Build and Test" in the badge in the ticket description.

comment:7 Changed 7 months ago by Matthias Köppe

These are likely just intermittent problems.

comment:8 Changed 7 months ago by Dima Pasechnik

Strangely, I cannot download https://ghcr.io/v2/homebrew/core/six/manifests/1.16.0_2-1 with wget or browser, but brew install six works.

comment:9 Changed 7 months ago by Dima Pasechnik

Reviewers: https://github.com/mkoeppe/sage/actions/runs/2218172551Dima Pasechnik
Status: needs_reviewpositive_review

lgtm otherwise

comment:10 Changed 7 months ago by Matthias Köppe

Thanks!

comment:11 Changed 7 months ago by Matthias Köppe

Priority: majorblocker

comment:12 Changed 7 months ago by Volker Braun

Branch: u/mkoeppe/gh_actions__macos___fix_test_of_optional_experimental_packages60adee640c3ba76a8a57c63152cd3eab70ffa660
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.