Opened 14 years ago

Closed 14 years ago

#4028 closed enhancement (fixed)

[with patch, positive review] doctest and improve sage/interfaces/axiom.py

Reported by: mhansen Owned by: was
Priority: minor Milestone: sage-3.1.2
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

trac_4028.patch (25.2 KB) - added by mhansen 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 14 years ago by mhansen

  • Summary changed from doctest and improve sage/interfaces/axiom.py to [with patch, needs review] doctest and improve sage/interfaces/axiom.py

Changed 14 years ago by mhansen

comment:2 Changed 14 years ago by mabshoff

  • Summary changed from [with patch, needs review] doctest and improve sage/interfaces/axiom.py to [with patch, positive review] doctest and improve sage/interfaces/axiom.py

One spelling error: "requires Axoim" (which Mike corrected) - other than that is passes doctests with and without Axiom installed. Mike went with me over the patch and answered questions. Positive review.

Cheers,

Michael

comment:3 Changed 14 years ago by mabshoff

  • Summary changed from [with patch, positive review] doctest and improve sage/interfaces/axiom.py to [with patch, needs work] doctest and improve sage/interfaces/axiom.py

Oops, with the original axiom running the doctest with -optional results in a fork bomb :(

Cheers,

Michael

comment:4 Changed 14 years ago by mabshoff

Looks like somehow the following ends up getting called:

sage -axiom -nox -noclef

If I run that from the command line it also starts a fork bomb.

Thoughts?

Cheers,

Michael

comment:5 Changed 14 years ago by mabshoff

  • Summary changed from [with patch, needs work] doctest and improve sage/interfaces/axiom.py to [with patch, positive review] doctest and improve sage/interfaces/axiom.py

It is all William's fault:

mabshoff@sage:/usr/local/bin$ pwd
/usr/local/bin
mabshoff@sage:/usr/local/bin$ cat axiom 
#!/bin/sh
sage -axiom $*

Cheers,

Michael

comment:6 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.alpha4

Note: See TracTickets for help on using tickets.