Opened 7 years ago

Closed 7 years ago

#4098 closed defect (fixed)

[with patch; positive review] "T1 = M1.hecke_operator(13^9)" blows up on 32 bit builds

Reported by: mabshoff Owned by: craigcitro
Priority: major Milestone: sage-3.1.2
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Raouf reports in http://groups.google.com/group/sage-support/browse_thread/thread/cf22177234f605a4

varro:~/sage-3.1.2.rc1 mabshoff$ ./sage
----------------------------------------------------------------------
| SAGE Version 3.1.2.rc1, Release Date: 2008-09-08                   |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

sage: M1 =  ModularSymbols(21,2)
sage: T1 =  M1.hecke_operator(13^8)
sage: trace1=T1.trace()
sage: print trace1
2651076189
sage: M1 =  ModularSymbols(21,2) 
sage: T1 =  M1.hecke_operator(13^9) 
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/Users/mabshoff/sage-3.1.2.rc1/<ipython console> in <module>()

/Users/mabshoff/sage-3.1.2.rc1/local/lib/python2.5/site-packages/sage/modular/hecke/module.py in hecke_operator(self, n)
    858            int n -- an integer at least 1.
    859         """
--> 860         return self.hecke_algebra().hecke_operator(n)
    861 
    862     def T(self, n):

/Users/mabshoff/sage-3.1.2.rc1/local/lib/python2.5/site-packages/sage/modular/hecke/algebra.py in hecke_operator(self, n)
    184             pass
    185         n = int(n)
--> 186         T = hecke_operator.HeckeOperator(self, n)
    187         self.__hecke_operator[n] = T 
    188         return T

/Users/mabshoff/sage-3.1.2.rc1/local/lib/python2.5/site-packages/sage/modular/hecke/hecke_operator.py in __init__(self, parent, n)
    360         HeckeAlgebraElement.__init__(self, parent)
    361         if not isinstance(n, int):
--> 362             raise TypeError, "n must be an int"
    363         self.__n = n
    364 

Attachments (1)

trac-4098.patch (1.6 KB) - added by was 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by was

comment:1 Changed 7 years ago by was

  • Summary changed from "T1 = M1.hecke_operator(13^9)" blows up on 32 bit builds to [with patch; needs review] "T1 = M1.hecke_operator(13^9)" blows up on 32 bit builds

comment:2 Changed 7 years ago by mabshoff

  • Milestone changed from sage-3.1.3 to sage-3.1.2
  • Summary changed from [with patch; needs review] "T1 = M1.hecke_operator(13^9)" blows up on 32 bit builds to [with patch; positive review] "T1 = M1.hecke_operator(13^9)" blows up on 32 bit builds

Nice and quick fix. Doctests pass on 32 bits, positive review.

Cheers,

Michael

comment:3 Changed 7 years ago by cremona

You got there before me but I agree.

comment:4 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.rc2

Note: See TracTickets for help on using tickets.