#4706 closed defect (invalid)
fix race condition between doctest creation and running
| Reported by: | mabshoff | Owned by: | mabshoff |
|---|---|---|---|
| Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | doctest coverage | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Reviewers: | ||
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description (last modified by chapoton)
With high -tp numbers (i.e. 16) on sage.math one will see similar issues to the one below:
sage -t -long devel/sage/sage/libs/symmetrica/symmetrica.pyx
File "/scratch/mabshoff/release-cycle/sage-3.2.alpha0/tmp/.doctest_symmetrica.py", line 29
>>> test_integer(Integer(1))###line 539:_sage_ >>> test_integer(1)
^
IndentationError: unexpected indent
This is likely a race condition between creating the file and the actual running of the doctest. The issue is not specific to -tp.
A potential solution might be to create all .doctest_$FOO files and then start running them. This might also fix the problem with
sage -t -long devel/sage/sage/symbolic/constants.pyx [0.1 s]
in Sage 3.2.1+ which is caused by no doctests being executed since (a) either there are no doctests in that file or (b) we are running optional doctests only.
Cheers,
Michael
don't apply anything!
Attachments (1)
Change History (5)
comment:1 Changed 7 years ago by mabshoff
- Description modified (diff)
Changed 7 years ago by was
comment:2 Changed 4 years ago by mderickx
- Description modified (diff)
- Report Upstream set to N/A
- Status changed from new to needs_review
comment:3 Changed 4 years ago by mhansen
- Milestone changed from sage-4.8 to sage-duplicate/invalid/wontfix
- Resolution set to invalid
- Status changed from needs_review to closed
I tihnk this can be closed as well.
comment:4 Changed 2 months ago by chapoton
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
I think this is an old ticket which can be closed and has been fixed in the mean time. At least during the parralel builds I did (and I did quite a few this sage days already) I never saw this message.