Opened 13 years ago
Closed 13 years ago
#6809 closed enhancement (fixed)
abstract_methods_of_class
| Reported by: | nthiery | Owned by: | nthiery |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.2 |
| Component: | misc | Keywords: | abstract methods |
| Cc: | sage-combinat | Merged in: | sage-4.2.alpha1 |
| Authors: | Nicolas M. Thiéry | Reviewers: | Florent Hivert |
| Report Upstream: | Work issues: | ||
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
Implement a utility abstract_methods_of_class which lists all the optional and mandatory abstract methods of the class.
Attachments (3)
Change History (8)
Changed 13 years ago by
comment:1 Changed 13 years ago by
Changed 13 years ago by
comment:2 Changed 13 years ago by
- Reviewers changed from Franco Saliola? to Florent Hivert
- Status changed from new to needs_review
I'm done reviewing this patch. It is good upto a small detail: the code access to a private attribute. I've added an accessor method.
I just uploaded a new version of the patch after review which add a is_optional method for better encapsulation (as suggested by former comment in the code).
Nicolas: please add a positive review when you finished reviewing my changes.
Cheers,
Florent
comment:3 Changed 13 years ago by
During his review of my change Nicolas spotted a missing blank line after 'EXAMPLE::'... I'm re-uploading the patch...
Cheers,
Florent
comment:4 Changed 13 years ago by
- Status changed from needs_review to positive_review
After Blank line added, Nicolas allows me to put the positive review.
Only apply the last trac_6809_abstract_methods_of_class.3.patch
Florent
comment:5 Changed 13 years ago by
- Merged in set to sage-4.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
New version with is_optional method