Opened 5 years ago

Closed 3 years ago

#9260 closed defect (fixed)

missing pointer in documentation

Reported by: zimmerma Owned by: mvngu
Priority: minor Milestone: sage-5.1
Component: documentation Keywords: sd40.5
Cc: kcrisman Merged in: sage-5.1.beta5
Authors: Karl-Dieter Crisman Reviewers: Keshav Kini
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The documentation from RealIntervalField says:

       See the documentation for ``RealIntervalField_class`` for many more
       examples.

However there is no documentation for RealIntervalField_class:

sage: RealIntervalField_class?
Object `RealIntervalField_class` not found.

Attachments (2)

trac_9260.patch (1.1 KB) - added by kcrisman 3 years ago.
Based on Sage 5.1.beta0
trac_9260.reviewer.patch (764 bytes) - added by kini 3 years ago.
apply to $SAGE_ROOT/devel/sage

Download all attachments as: .zip

Change History (18)

comment:1 Changed 5 years ago by kcrisman

  • Cc kcrisman added

comment:2 Changed 4 years ago by kcrisman

Current code is actually

    See the documentation for :class:`RealIntervalField_class` for many more
    examples.

So this would just have to add a little so that users at the command line could see where to find this; in the documentation it would still look the same and have the right link.

comment:3 Changed 4 years ago by zimmerma

Karl-Dieter,
do you know how to find the documentation from the command line?

sage: :class:RealIntervalField_class?
Object `:class:RealIntervalField_class` not found.

Paul

comment:4 Changed 4 years ago by kcrisman

Yes, and I thought one of my students had made a patch for this. It turns out to live in sage.rings.real_mpfi.RealIntervalField_class?

comment:5 Changed 3 years ago by kcrisman

  • Authors set to Karl-Dieter Crisman
  • Status changed from new to needs_review

I see what you were asking now in comment:3. Most Sage documentation now has these hyperlinks, but it does mean one has to ignore the backticks and things like :class or :meth:. I think this is standard now.

sage.rings.real_mpfi.RealIntervalField_class?

is the correct command, and the patch coming up changes the doc so that this can at least be found, modulo the extra formatting.

Changed 3 years ago by kcrisman

Based on Sage 5.1.beta0

comment:6 Changed 3 years ago by kcrisman

  • Keywords sd40.5 added

comment:7 Changed 3 years ago by kini

  • Status changed from needs_review to positive_review

Other than the fact that you have created an excessively long line in the docstring, this ticket looks good to go.

Changed 3 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:8 Changed 3 years ago by kini

Here's a reviewer patch to fix the "excessively long line", per your suggestion :)

comment:9 Changed 3 years ago by kini

patchbot, please, please, please apply trac_9260.patch trac_9260.reviewer.patch (pretty please)

Last edited 3 years ago by kini (previous) (diff)

comment:10 Changed 3 years ago by jdemeyer

Please fill in your real name in the Author / Reviewer fields.

comment:11 Changed 3 years ago by kini

  • Reviewers set to Keshav Kini

Done.

comment:12 Changed 3 years ago by kcrisman

Hmm, that is a good change in the reviewer patch - I wasn't aware that syntax was an option.

Jeroen, I think you know who kini is - wouldn't that have taken fewer characters? ;-)

comment:13 Changed 3 years ago by kini

Jeroen is correct in asking me to add my name. Ideally a release manager should need to do as little work as possible - and what work he does do should be limited to administrative oversight. The more automation we can add to the system of getting Sage releases out, the better.

comment:14 Changed 3 years ago by kcrisman

I agree that you (or I) should have done it! I was just pointing out that in this particular case it actually took him more effort than doing it himself - hence the winky emoticon. Presumably this will save him effort in the long run, though, I agree.

comment:15 Changed 3 years ago by kini

Well, since he left exactly the same message on two other tickets which I had forgotten to put my name on, there's a strong possibility that he had scripted it :) And that's a good thing!

comment:16 Changed 3 years ago by jdemeyer

  • Merged in set to sage-5.1.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.