Add an example plotting spherical harmonics to spherical_plot3d's docstring

[olazo]

Ploting Spherical Harmonics is one of the most useful ways to use spherical_plot3d. Adding an example of that would be nice.

Apply:

1. trac-9655_spherical-harmonic-example.patch​
2. trac-9655_reviewer.patch​

[mvngu]

Here are some issues with olazo's patch:

• The "User" should be filled with your real name and preferred contact email address. I have fixed this in my update of olazo's patch; see trac-9655_spherical-harmonic-example.patch​.
• The code in olazo's patch does not conform to Python coding conventions. In particular, see ​PEP 8. This is fixed in my reviewer patch; see trac-9655_reviewer.patch​. Someone other than me needs to review that. If my patch gets a positive review, the whole ticket gets a positive review.

[olazo]

Replying to mvngu:

Here are some issues with olazo's patch:

• The "User" should be filled with your real name and preferred contact email address. I have fixed this in my update of olazo's patch; see trac-9655_spherical-harmonic-example.patch​.

This is the first patch I produced using mecurial queues. At some point I recieved a warning about User not being defined, but how do I set it up? I mean other than directly editing the .patch

• The code in olazo's patch does not conform to Python coding conventions. In particular, see ​PEP 8. This is fixed in my reviewer patch; see trac-9655_reviewer.patch​. Someone other than me needs to review that. If my patch gets a positive review, the whole ticket gets a positive review.

I was unaware of such conventions...

[mvngu]

Replying to olazo:

At some point I recieved a warning about User not being defined, but how do I set it up? I mean other than directly editing the .patch

You should use the Mercurial configuration file ~/.hgrc. Here's a template for your ~/.hgrc file:

[ui]
editor = /usr/bin/vim
username = Carl Friedrich Gauss <cfgauss@uni-goettingen.de>

[extensions]
# Enable the Mercurial queues extension.
hgext.mq =
# Enable the record, qrecord and crecord extensions for cherry picking.
hgext.record =

[diff]
# Format diff output using Git style.
git = True
# Prevent qrefresh from updating timestamps. If you're keeping your patch
# queue under revision control, it can be quite annoying when every qrefresh
# updates the timestamps in your patch. The following prevents this from
# happening.
nodates = 1

Change your username accordingly.

I was unaware of such conventions...

See this page of the Developer's Guide for more details about coding conventions used by the Sage library.

[spice]

This is the first patch I've ever reviewed, so a second look by someone else might not be a bad idea.

[mvngu]

Replying to spice:

This is the first patch I've ever reviewed, so a second look by someone else might not be a bad idea.

Please put down your real name in the field "Reviewer(s):".

[spice]

Done.

Thanks Minh.