Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Prediction Service - DNS prefetching #340

Merged
merged 1 commit into from Aug 19, 2018
Merged

Disable Prediction Service - DNS prefetching #340

merged 1 commit into from Aug 19, 2018

Conversation

@bbondy
Copy link
Member

@bbondy bbondy commented Aug 19, 2018

Fix brave/brave-browser#766

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
@bbondy
Disable Prediction Service - DNS prefetching
Loading status checks…
c89f616 
Fix brave/brave-browser#766
@bbondy bbondy self-assigned this Aug 19, 2018
@bbondy bbondy requested a review from yrliou Aug 19, 2018
@yrliou
yrliou approved these changes Aug 19, 2018
View changes
Copy link
Member

@yrliou yrliou left a comment

LGTM
@yrliou yrliou merged commit 0126337 into master Aug 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simonhong simonhong mentioned this pull request Aug 19, 2018
Closed
@bbondy bbondy deleted the prediction-service branch Aug 20, 2018
NejcZdovc pushed a commit that referenced this pull request Sep 18, 2019
@ryanml
Merge pull request #340 from brave/contribution-nonverified
ab96c78 
Adds reserved amount to wallet summary
NejcZdovc pushed a commit that referenced this pull request Sep 19, 2019
@ryanml
Imported from brave-ui: Merge pull request #340 from brave/contributi…
d92b754 
…on-nonverified

Adds reserved amount to wallet summary
@the-rocinante the-rocinante mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bbondy @yrliou