bugFreeciv - Bugs: bug #15663, Custom Scenarios are not show in...

 
 
Show feedback again

bug #15663: Custom Scenarios are not show in "Start Scenario Game" list

Submitted by:  Engla <englabenny>
Submitted on:  Sat Mar 20 23:43:10 2010  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Engla <englabenny>Open/Closed: Closed
Release: 2.2Operating System: None
Planned Release: 2.2.1, 2.3.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue Mar 30 14:04:52 2010, SVN revision 17210:

Improve the GTK+ client "Start Scenario Game" page

Show scenarios from ~/.freeciv/scenarios/ in the scenario pane in the
GTK+ client, these were missing in the 2.2 release, yet it is there we
save scenarios to from the editor.

For scenarios with empty scenario names, show the filename instead.
Show the file basename in an information field below the description,
so you can distinguish like-named scenarios.

Introduce a utility function skip_to_basename in utility/shared.

See gna bug #15663

(Browse SVN revision 17210)

Engla <englabenny>
Project MemberIn charge of this item.
Tue Mar 30 14:04:37 2010, SVN revision 17209:

Improve the GTK+ client "Start Scenario Game" page

For scenarios with empty scenario names, show the filename instead.
Show the file basename in an information field below the description,
so you can distinguish like-named scenarios.

Introduce a utility function skip_to_basename in utility/shared.

See gna bug #15663

(Browse SVN revision 17209)

Engla <englabenny>
Project MemberIn charge of this item.
Sun Mar 28 18:14:49 2010, comment #4:

Patches against 2.2 and trunk. Trunk already shows the scenarios we want to see, so the patch is smaller.

We show an information field below the description with the filename (basename) of the scenario, so you can distinguish like-named scenarios (With the expectation that it will occur). Showing the full path would be very ugly and use a lot of space.

(file #8713, file #8714)

Engla <englabenny>
Project MemberIn charge of this item.
Wed Mar 24 23:46:11 2010, comment #3:

This simple diff improves 2.2 a lot, by displaying scenarios from ~/.freeciv/scenarios (where Save Scenario saves them), and additionally using the filename if the scenario name is an empty string.

(file #8641)

Engla <englabenny>
Project MemberIn charge of this item.
Wed Mar 24 22:56:45 2010, comment #2:

Trunk is much better, or at least it seems to list all scenarios in working directory and most importantly in the .freeciv/scenarios directory.

Trunk must be opening all files to read the scenario titles, (and it takes a long time if you have a lot of savegames in the working directory, but that's not the common case).

However

  • There is no obvious ordering
  • We still list savegames that are not scenarios
  • There are many scenarios with duplicate names, or even empty names (blank lines in the list). This ought to be common if you are editing scenarios in different versions.

I think the filename should be visible somehow, and used as fallback if the name is empty. It would be really nice if like-named scenarios were automatically disambiguated by filename.

It would be nice if a 2.2 bugfix could align a bit more with trunk, with some of these above concerns addressed as well.

Is it too risky to use a heuristic and try to detect autosave savefiles by filename only? That way we don't need to decompress & read all autosaves that we find. Again, this might not be an issue for the common user.

Engla <englabenny>
Project MemberIn charge of this item.
Wed Mar 24 22:25:59 2010, comment #1:

What is the behaviour in the trunk branch?

pepeto <pepeto>
Project Member
Sat Mar 20 23:43:10 2010, original submission:

"Start Scenario Game" screen in the Gtk+ client does not include scenarios from ~/.freeciv/scenarios

1. Most notably, scenarios saved with Save Scenario.. from the editor are not listed in "Start Scenario Game"

2. The server command '/list scenarios' produces a different list, I don't think it lists scenarios from ~/.freeciv/scenarios either! It includes lots of savegames from ~/ though.

Engla <englabenny>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by englabenny (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Mar 30 14:05:44 2010englabennyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun Mar 28 18:14:49 2010englabennyAttached File-=>Added 0001-Improve-the-GTK-client-Start-Scenario-S2_2.patch, #8713
      Attached File-=>Added 0001-Improve-the-GTK-client-Start-Scenario-Game-page.patch, #8714
      Priority1 - Later=>5 - Normal
      StatusNone=>Ready For Test
      Assigned toNone=>englabenny
      Planned Release=>2.2.1, 2.3.0
    Sun Mar 28 15:19:33 2010englabennyDependencies-=>bugs #15729 is dependent
    Wed Mar 24 23:46:11 2010englabennyAttached File-=>Added list_scenarios_2_2.diff, #8641
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup