bugFreeciv - Bugs: bug #21636, Wrong diplomat for two stage...

 
 
Show feedback again

bug #21636: Wrong diplomat for two stage actions when in a diplomat queue

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Tue Feb 11 00:43:51 2014  
 
Category: client-gtk-3.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Release: 2.6.0, 2.5.0, 2.4.2Operating System: None
Planned Release: 2.6.0, 2.5.0, 2.4.4Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Sep 5 08:53:22 2014, SVN revision 26233:

Gtk clients: Don't store spy action information in static variables

Unlike the other clients the Gtk clients won't wait until the previous spy
action is complete, follow up questions and all, before the next spy action
dialog is shown.

They used to store information like actor and target in static variables.
Follow up questions would use those variables. The variables would be
overwritten when the next spy action selection dialog was opened. This would
cause orders from follow up questions to be issued to the wrong actor and
against the wrong target.

Changes:

  • Use actor and target information sent by the server with the follow up

questions now that the API forwards it.

  • Store actor and target information in the GUI widgets using gpointer so

the functions called by the GUI can get it from there.

See bug #21636

(Browse SVN revision 26233)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed Sep 3 17:36:58 2014, comment #11:

2.4 version.

(file #22017)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed Sep 3 15:05:23 2014, comment #10:

Not fixed for 2.4 yet.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed Sep 3 14:24:06 2014, SVN revision 26205:

Gtk clients: Don't store spy action information in static variables

Unlike the other clients the Gtk clients won't wait until the previous spy
action is complete, follow up questions and all, before the next spy action
dialog is shown.

They used to store information like actor and target in static variables.
Follow up questions would use those variables. The variables would be
overwritten when the next spy action selection dialog was opened. This would
cause orders from follow up questions to be issued to the wrong actor and
against the wrong target.

Changes:

  • Use actor and target information sent by the server with the follow up

questions now that the API forwards it.

  • Store actor and target information in the GUI widgets using gpointer so

the functions called by the GUI can get it from there.

See bug #21636

(Browse SVN revision 26205)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed Sep 3 14:05:03 2014, SVN revision 26204:

Gtk clients: Don't store spy action information in static variables

Unlike the other clients the Gtk clients won't wait until the previous spy
action is complete, follow up questions and all, before the next spy action
dialog is shown.

They used to store information like actor and target in static variables.
Follow up questions would use those variables. The variables would be
overwritten when the next spy action selection dialog was opened. This would
cause orders from follow up questions to be issued to the wrong actor and
against the wrong target.

Changes:

  • Use actor and target information sent by the server with the follow up

questions now that the API forwards it.

  • Store actor and target information in the GUI widgets using gpointer so

the functions called by the GUI can get it from there.

See bug #21636

(Browse SVN revision 26204)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue Sep 2 01:57:46 2014, comment #7:

2.5 version and updated trunk version.

(file #21995, file #21996)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Mon Sep 1 19:03:21 2014, comment #6:

(Versions for 2.4 and 2.5 will come later)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Mon Sep 1 19:00:06 2014, comment #5:

Don't store actor and target information in global variables.

(file #21990)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Sat Aug 9 12:58:21 2014, comment #4:

2.4.3 is imminent and there's no patch (it's probably too late to rush one in), so removing 2.4.3 target.

Jacob Nevins <jtn>
Project Administrator
Sat Feb 15 17:56:13 2014, comment #3:

> Is there any connection to another unit type with action popups, caravans.

I haven't checked if a caravan dialog can cause the same issue. I wouldn't be surprised if it would.

> In any case I'd like to see diplomat & caravan actions brought together

Me too.

> Do you have any plans of this?

Yes. I decided to move the evaluation of action enablers to the server side first to avoid stepping on my own toes.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Fri Feb 14 17:22:15 2014, comment #2:

Is there any connection to another unit type with action popups, caravans.

In any case I'd like to see diplomat & caravan actions brought together, so that long standing limitation that same unit cannot sensibly have both diplomat and caravan flag would be lifted (problem currently being that for such a unit only one action popup would be presented, so there's no way to make actions of the other kind)
Do you have any plans of this? I also assume that it would mean enabling caravan actions via action enablers.

Marko Lindqvist <cazfi>
Project Administrator
Fri Feb 14 15:38:03 2014, comment #1:

Is the behavior that the popup asking the player to select actions for the next unit in the diplomat queue before questions are answered intended? If it is intended (and still wanted) a fix can be based on patch #4502. If it isn't intended making it wait for the follow up questions would fix this but introduce bug #21646.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue Feb 11 00:43:51 2014, original submission:

Some diplomat actions require two steps of input. The first step selects the action, the second give details like what improvement to sabotage. The Gtk client moves on to the next diplomat waiting for user input as soon as an action is chosen. Since a lot of data is shared this confuses the second diplomat.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by sveinung (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Sep 5 08:54:19 2014sveinungStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed Sep 3 17:36:58 2014sveinungAttached File-=>Added 2.4-Gtk-clients-Don-t-store-spy-action-information-in-st.patch, #22017
      StatusIn Progress=>Ready For Test
    Wed Sep 3 15:05:23 2014sveinungStatusReady For Test=>In Progress
    Tue Sep 2 01:57:46 2014sveinungAttached File-=>Added trunk-Gtk-clients-Don-t-store-spy-action-information-in-st.patch, #21995
      Attached File-=>Added 2.5-Gtk-clients-Don-t-store-spy-action-information-in-st.patch, #21996
    Mon Sep 1 19:03:21 2014sveinungAssigned toNone=>sveinung
    Mon Sep 1 19:00:06 2014sveinungAttached File-=>Added Gtk-clients-Don-t-store-spy-action-information-in-st.patch, #21990
      StatusNone=>Ready For Test
    Sat Aug 9 12:58:21 2014jtnPlanned Release2.6.0, 2.5.0, 2.4.3=>2.6.0, 2.5.0, 2.4.4
    Fri Feb 14 11:38:59 2014sveinungRelease2.6.0=>2.6.0, 2.5.0, 2.4.2
      Planned Release=>2.6.0, 2.5.0, 2.4.3
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup