patchFreeciv - Patches: patch #6496, Look ws2tcpip.h for socklen_t...

 
 
Show feedback again

patch #6496: Look ws2tcpip.h for socklen_t definition

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue Oct 27 16:31:55 2015  
 
Category: bootstrapPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.2, 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Nov 1 18:56:47 2015, SVN revision 30361:

Do not include , mostly reverting patch #6496

See bug #24000

(Browse SVN revision 30361)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Oct 29 19:26:47 2015, SVN revision 30304:

Look for socklen_t definition from .

See patch #6496

(Browse SVN revision 30304)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Oct 29 19:26:41 2015, SVN revision 30303:

Look for socklen_t definition from .

See patch #6496

(Browse SVN revision 30303)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Oct 29 19:26:35 2015, SVN revision 30302:

Look for socklen_t definition from .

See patch #6496

(Browse SVN revision 30302)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Oct 27 16:31:55 2015, original submission:

Looking through fc_config.h generated for the crosser based build I noticed that HAVE_SOCKLEN_T was not defined.

Attached patch makes such builds to get socklen_t definition from ws2tcpip.h (no behavioral changes expected as we already we're fallbacking to identical definition):

- Search socklen_t from Windows specific header ws2tcpip.h
- Do not fail the socklen_t configure check just because (any) system lacks headers needed providing socklen_t in some other system
- Include ws2tcpip.h to netintf.h for getting the definition also when doing the actual compilation

For S2_6/TRUNK we should define HAVE_WS2TCPIP_H as a public macro in freeciv_config.h, but doing that alone, without fixing rest of bug #23989, would just cause compilation problems -> handle all of it in bug #23989.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25487:  Ws2TcpIpSocklenT.patch added by cazfi (1kB - text/plain-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Oct 29 19:26:59 2015cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue Oct 27 16:31:55 2015cazfiAttached File-=>Added Ws2TcpIpSocklenT.patch, #25487
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup